Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11769 - Change USB charge mode detection key

Attached to Project: Rockbox
Opened by MichaelGiacomelli (saratoga) - Monday, 22 November 2010, 02:06 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Monday, 16 May 2011, 22:31 GMT+2
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Mostly for historical reasons, rockbox requires the user to hold down a key to enter charge mode when plugging in USB on a number of targets. Unfortunately, this has several problems on some targets, including:

1) The key is often quite different on different devices, even those with fairly similar layouts, so its often not obvious what to press.

For example, the gigabeat S and sansas all have a center select buttons, and a menu/home type button. On the S, the menu button enters charge mode. On the Sansas, select does it.

2) On some devices, its very difficult to hold the USB charge mode while inserting USB for mechanical reasons.

For example, on the Nano 2G or Sansa Clip, its extremely easy to hit another button while trying to force a USB plug in because the devices are both tiny and very sensitive.


To address the latter, the current code defines a USBPOWER_BTN_IGNORE, which is ignored if its also pressed. However for nearly all targets, the button is defined to something uesless, presumably because its purpose is not commented in the code.

This patch throws all that out. If you click any button while inserting USB, you will get charge mode. Asking on IRC, people seemed in favor of this approach. However, it is possible there are targets out there where this could make it difficult to enter USB mode due to awkward button placement. If so, this patch should be updated to work around that.

I'd appreciate feedback.
   usb_charge_v2.patch (2.7 KiB) 
 firmware/usb.c        |    6 +-----
 firmware/export/usb.h |   50 --------------------------------------------------
 2 files changed, 1 insertion(+), 55 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Monday, 16 May 2011, 22:31 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r29889.
Comment by Frank Gevaerts (fg) - Monday, 22 November 2010, 12:31 GMT+2
If this is done, the manual should be updated as well. The attached patch may be a good start.
   usb_button_manual.diff (0.8 KiB) 
 manual/rockbox_interface/main.tex |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comment by sideral (sideral) - Monday, 22 November 2010, 15:01 GMT+2
This task seems to be related to, and possibly a duplicate of, FS#10198.
Comment by Frank Gevaerts (fg) - Monday, 22 November 2010, 15:05 GMT+2
sideral: vaguely related, maybe. Duplicate, how?
Comment by sideral (sideral) - Monday, 22 November 2010, 15:34 GMT+2
I think it may be a duplicate because FS#10198 implements the same functionality: If you click any button while inserting USB, you will get charge mode. (FS#10198 goes a step beyond that and also allows configuring the opposite behavior: default to charge only, pressing any button forces USB slave mode.)
Comment by MichaelGiacomelli (saratoga) - Monday, 16 May 2011, 00:17 GMT+2
Updated to leave in the check for button power on the Player and Ondio since these require it when booting from a flashed device. Also, resync manual changes.
   usb_charge_v3.patch (3.7 KiB) 
 firmware/usb.c                    |    6 -----
 firmware/export/usb.h             |   45 ++------------------------------------
 manual/rockbox_interface/main.tex |    6 ++++-
 3 files changed, 9 insertions(+), 48 deletions(-)

Loading...