Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11800 - Drop Shadow Tag for WPS

Attached to Project: Rockbox
Opened by Fred Bauer (freddyb) - Thursday, 09 December 2010, 04:13 GMT+2
Last edited by Fred Bauer (freddyb) - Saturday, 05 March 2011, 21:20 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Low
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This simply adds a format tag to make drop shadows for text in the while playing screen. The format of the tag is %as(2) where 2 is the number of pixels the shadow is offset down and right. The shadow is rendered in the viewport's background color.

This would render white text with a black background offset one pixel down and right:
%Vf(ffffff)%Vb(000000)
%as(1)Text

   shadow.png (44.5 KiB)
   drop_shadows_v1.patch (6.4 KiB) 
 lib/skin_parser/tag_table.c         |    1 +
 lib/skin_parser/tag_table.h         |    1 +
 apps/gui/skin_engine/skin_display.h |    3 ++-
 apps/gui/skin_engine/skin_parser.c  |    2 +-
 apps/gui/skin_engine/skin_render.c  |   15 +++++++++------
 apps/gui/skin_engine/skin_display.c |   24 +++++++++++++++++++++++-
 6 files changed, 37 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Fred Bauer (freddyb)
Saturday, 05 March 2011, 21:20 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  No interest.
Comment by Jonathan Gordon (jdgordon) - Thursday, 09 December 2010, 04:22 GMT+2
%a probably isnt the best tag prefix for it.
how does it look when scrolling? I imagine either horrible or shadow isnt drawn?
Comment by Fred Bauer (freddyb) - Thursday, 09 December 2010, 05:15 GMT+2
The shadow isn't drawn on scrolling lines. I might wait and see if there's any interest before I tackle that. What tag should I use?

Loading...