Rockbox

Tasklist

FS#11818 - rework ppmviewer to fit our shiny new imageviewer framework

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Monday, 20 December 2010, 14:23 GMT
Last edited by Marcin Bukat (MarcinBukat) - Sunday, 09 January 2011, 13:27 GMT
Task Type Bugs
Category Battery/Charging
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch moves ppm decoder to imageviewer.
This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Sunday, 09 January 2011, 13:27 GMT
Reason for closing:  Accepted
Additional comments about closing:  r29012
Comment by Teruaki Kawashima (teru) - Tuesday, 21 December 2010, 14:35 GMT
- values added to image_decoder.[ch] need to be surrounded by #if.
- return value of read_ppm isn't checked in load_image in ppm.c
- header of ppm.c contains unrelated comments.
- apps/plugins/CATEGORIES seems to be sorted by plugin name, it would be better to follow the convention.
Comment by Marcin Bukat (MarcinBukat) - Tuesday, 21 December 2010, 20:12 GMT
Thanks teru for review. Please take a look at this fixed version.
Comment by Teruaki Kawashima (teru) - Wednesday, 22 December 2010, 09:14 GMT
- file descriptor is not closed.
- i get a warning when compiling.
/home/teru/rockbox/original/apps/plugins/imageviewer/ppm/ppm.c: In function ‘load_image’:
/home/teru/rockbox/original/apps/plugins/imageviewer/ppm/ppm.c:81: warning: ‘rc’ may be used uninitialize
read_ppm shouldn't be in if (!iv->running_slideshow).
- remove ppmviewer from viewers.config.

it looks fine otherwise.
Comment by Marcin Bukat (MarcinBukat) - Wednesday, 22 December 2010, 12:40 GMT
new version

Loading...