This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11821 - iPod Colour: Database data aborts on init/update
Attached to Project:
Rockbox
Opened by Hayden Pearce (St.) - Tuesday, 21 December 2010, 10:07 GMT+2
Last edited by sideral (sideral) - Friday, 04 March 2011, 20:05 GMT+2
Opened by Hayden Pearce (St.) - Tuesday, 21 December 2010, 10:07 GMT+2
Last edited by sideral (sideral) - Friday, 04 March 2011, 20:05 GMT+2
|
Detailsr28861
I'm getting data aborts when I attempt to initialise the database when using the current build, it finds all the files fine, but fails on the second step (after reboot) during the 1~9 count. I had thought it was possibly dodgy metadata tags in a file(s) so I tried adding small chunks to the DB at a time, but it also failed there too. I worked out that it's not the files themselves from installing 3.7/.1 release build(s), the database updates and initialises as expected in these builds. After that, if I then update the build to SVN head and add some tracks and update the database it aborts again so I have to turn auto update off and downgrade to the release build to add tracks to the database. This is present for me on two different devices (iPod Colour 64GB CF and iPod Colour 60GB HDD). |
This task depends upon
Closed by sideral (sideral)
Friday, 04 March 2011, 20:05 GMT+2
Reason for closing: Out of Date
Additional comments about closing: Closed upon request
Friday, 04 March 2011, 20:05 GMT+2
Reason for closing: Out of Date
Additional comments about closing: Closed upon request
FS#11723. Can you try backing out the related changes (r28647, r28646, r28645; for your convenience, I've attached an experimental patch that does just that) and check whether the problem still occurs?/home/fraser/src/rockbox/apps/tagcache.c: In function ‘tagcache_fill_tags’:
/home/fraser/src/rockbox/apps/tagcache.c:1652: error: too many arguments to function ‘get_tag_numeric’
I generated my own backout patch after updating my tree:
svn diff -r28647:28644 > dbfix.patch
patch -p0 < dbfix.patch
...and the build fails with the same error.
I'm not at all familiar with the code but I'll take a look.
I made one change to the patched tagcache.c:
1652c1652
< id3->offset = get_tag_numeric(entry, tag_lastoffset, idx_id);
---
> id3->offset = get_tag_numeric(entry, tag_lastoffset);
I can confirm that the resulting build solves the data abort during database commit on my iPod Video, but I don't know the consequences of dropping the idx_id. The build appears to run normally so far.
If this patch fixes your problem, I'd love to help finding the real issue in the fix it reverts. Unfortunately I don't have an iPod (any make).
Is the issue reproducible (with the back-out patch removed) in the simulator?
Can you reproduce the issue with a small set of files that you could share with me?
For the convenience of anyone else wanting to try the experimental patch: Here's an updated version of the patch that does not require additional manual changes.
joatca, I'd like to know whether you still need my experimental patch (which would indicate a problem in the code it removes). Could you please try an unpatched recent SVN version (not release 3.8)? I'd like to close this issue unless you report the problem persists.