Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11828 - Fix core mod metadata parser

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 23 December 2010, 20:35 GMT+2
Last edited by Thomas Martitz (kugel.) - Friday, 21 January 2011, 21:09 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The mod metadata parser checks if the file in question is a mod file in a very poor manner: not at all. This is a problem when building the database on a PC, because any file that has .mod is accepted, including those text files generated during Linux kernel compilation.

Based on MikiMod, I made this patch to fix it. Please let me know if it rejects any *valid* mod file. It should now accept the same files that the MikMod plugin accepts.
   fix_mod_parser.patch (2.5 KiB) 
 b/apps/metadata/mod.c |   62 +++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 52 insertions(+), 10 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Friday, 21 January 2011, 21:09 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r29105
Comment by Jason Yu (captainkewl) - Wednesday, 05 January 2011, 05:39 GMT+2
Looks fine. Invalid .mod files are correctly ignored during database generation and skipped over if they make it into a playlist. Only thing that sticks out to me is that Mikmod is spelled wrong.
Comment by MichaelGiacomelli (saratoga) - Friday, 21 January 2011, 01:38 GMT+2
It would be nice to get this committed so that the database is a little more stable.

Loading...