Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11862 - Add a frequency response graph to the graphic equalizer menu

Attached to Project: Rockbox
Opened by Attilio Scotolati (nexor) - Thursday, 06 January 2011, 04:00 GMT+2
Last edited by Alexander Levin (fml2) - Thursday, 06 January 2011, 22:22 GMT+2
Task Type Patches
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical". :-)

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.
   eq_resp_graph.patch (7.6 KiB) 
 apps/menus/eq_menu.c |   86 +++++++++++++++++++++++++++++++++++++++++++++++++++
 apps/fixedpoint.c    |    7 +---
 apps/fixedpoint.h    |    9 ++++-
 3 files changed, 97 insertions(+), 5 deletions(-)

This task depends upon

Comment by Marcin Bukat (MarcinBukat) - Saturday, 08 January 2011, 14:19 GMT+2
patch: **** malformed patch at line 105: @@ -414,9 +504,32 @@
Comment by Hayden Pearce (St.) - Saturday, 08 January 2011, 18:19 GMT+2
I got the same here, was this patch built/edited by hand?

There are certainly some oddities present in the way the patch is laid out.
I managed to get it to compile, but I haven't tested it yet.


[St.]
Comment by Hayden Pearce (St.) - Saturday, 08 January 2011, 18:22 GMT+2
BTW, the EQ is already "graphical"...

What do you think you're seeing on screen when using the player other than...*graphics!* ;)
I think "Slightly more graphical than the already graphical graphical EQ" is a bit of a mouthful though.


[St.]
Comment by Attilio Scotolati (nexor) - Saturday, 08 January 2011, 18:56 GMT+2
The EQ as of now is parametric with silders, which are a graphical element I admit, but IMHO not enough to make it graphical...
Sorry for the patch not working, I've edited it by hand, I'm a newcomer to C and patches (had to learn FP programming too...), hence the mistake.
I've later found out that I was using the wrong equations to get the frequency response, so I'm now trying to address this, and meanwhile haven't a working patch. BTW I also have to think about smaller screens compatibility: free time is little and this could take a while!
Comment by JoshuaChang (JoshuaChang) - Friday, 14 January 2011, 01:37 GMT+2
the patch seems have some problems, i tried to fix the patch error, but after compile, the EQ interface was dead...(cowon d2+)
Comment by Boris Gjenero (dreamlayers) - Tuesday, 15 November 2011, 18:29 GMT+2
I like the idea, as long as the graph shows the frequency response with reasonable accuracy. Here's a patch which applies cleanly on r30989 and works on the 5G iPod sim. Unfortunately, it doesn't work on my 5G iPod. I never actually saw the EQ screen there: one time I got a prefetch abort and another time I got a lockup.

BTW. recountdiff from patchutils helped with the original patch.
   eq_resp_graph-r30989.patch (7.5 KiB) 
 apps/menus/eq_menu.c |  123 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 apps/fixedpoint.c    |    7 +-
 apps/fixedpoint.h    |    9 +++
 3 files changed, 133 insertions(+), 6 deletions(-)

Comment by Marcin Bukat (MarcinBukat) - Tuesday, 15 November 2011, 18:44 GMT+2
dreamlayers: have you checked actual equations used? Original author states that equations are wrong in original patch but he seems to abandon the idea.
Comment by Boris Gjenero (dreamlayers) - Friday, 18 November 2011, 04:37 GMT+2
No, I did not check the equations.

Loading...