Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11893 - wpsbuild.pl rewrite

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Thursday, 20 January 2011, 23:33 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Saturday, 04 June 2011, 23:48 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is complete rewrite of wpsbuild.pl. The differences from old wpsbuild are:
1) Now it uses xml format for WPSLIST file (to make it more consistent) with help of XML::Simple CPAN module.
2) It scans all skin files for graphics needed (not only .wps)
3) Takes lcd dimensions parsing firmware/export/config/modelname.h file directly (instead of bizarre gcc preprocessing and regexp matching)
4) Should be easy to extend (for example to include rec skins if this ever happens)

At first I was thinking about fixing fms support in wpsbuild.pl but it was very hard to follow the code and writing something new from scratch was much easier.
   wpsbuild2.patch (34 KiB) 
 b/tools/buildzip.pl |    6 
 b/wps/WPSLIST.xml   |  300 +++++++++++++++++++++
 b/wps/wpsbuild2.pl  |  716 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1020 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Saturday, 04 June 2011, 23:48 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  no going to be merged anytime soon
Comment by Marcin Bukat (MarcinBukat) - Friday, 21 January 2011, 22:34 GMT+2
1) wpsbuild2.pl - fix getlcdsizes() to parse correctly LCD defines if there is a comment in the same line
2) buildzip.pl - fix call to wpsbuild2.pl in verbose mode
   wpsbuild2_v2.patch (34.1 KiB) 
 b/tools/buildzip.pl |    8 
 b/wps/WPSLIST.xml   |  300 +++++++++++++++++++++
 b/wps/wpsbuild2.pl  |  716 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1021 insertions(+), 3 deletions(-)

Comment by Marcin Bukat (MarcinBukat) - Tuesday, 25 January 2011, 23:33 GMT+2
Changes compared to v2
wpsbuild2.pl
1) some code refactor
2) many small fixes
3) some sanity checks added
4) run with warnings turned on
5) handle all theme related configuration tags

wpsbuild2.pl/buildzip.pl
1) Handle classic_statusbar in wpsbuild2.pl (where this should be!)

WPSLIST.xml
1) reset backdrop to default if needed
2) explicitly state that cabbiev2 uses classic_statusbar.sbs
   wpsbuild2_v3.patch (46.3 KiB) 
 b/tools/buildzip.pl               |   46 +-
 b/wps/WPSLIST.xml                 |  304 ++++++++++++++
 b/wps/classic_statusbar.color.sbs |  104 ++++
 a/wps/classic_statusbar.sbs       |  104 ----
 b/wps/wpsbuild2.pl                |  810 ++++++++++++++++++++++++++++++++++++++
 5 files changed, 1242 insertions(+), 126 deletions(-)

Loading...