Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12041 - Backdrops outside of .rockbox/backdrops can't be used any more

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Saturday, 02 April 2011, 18:15 GMT+2
Last edited by Frank Gevaerts (fg) - Sunday, 10 April 2011, 15:26 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.8
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Since r28073/r28074, bmp files outside of .rockbox/backdrops can not be used at all any more. Before then, they could be set but the setting didn't survive a reboot.

The attached patch checks for .rockbox/backdrops and doesn't show the relevant context menu item if invoked outside of .rockbox/backdrops. I'm not entirely sure if the check is always correct, or if maybe there's a better way to do it.

Ideally of course the backdrop setting should accept any path instead of just relative paths based in .rockbox/backdrops (or even just filenames?).
   backdrop.diff (1 KiB) 
 apps/onplay.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Sunday, 10 April 2011, 15:26 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r29700
Comment by Frank Gevaerts (fg) - Saturday, 02 April 2011, 19:24 GMT+2
This patch allows loading of backdrops from anywhere, and keeps those backdrops after reboot.

I'm not entirely sure if my change to settings_list.c is correct, but the thing seems to work for me.

As far as I can see, the new code structure since r28073 doesn't make it easy to go back to the old behaviour of only persisting backdrops in .rockbox/backdrops. I'm not sure if we really want to go back to that though, most people used to be surprised by that behaviour.
   backdrop_2.diff (3.4 KiB) 
 apps/onplay.c                         |   15 +++------------
 apps/gui/skin_engine/skin_backdrops.c |   13 ++++++++++---
 apps/settings.h                       |    2 +-
 apps/settings_list.c                  |    2 +-
 4 files changed, 15 insertions(+), 17 deletions(-)

Comment by Frank Gevaerts (fg) - Monday, 04 April 2011, 11:09 GMT+2
A simplified version of the previous one, thanks to a better understanding of how the settings actually work. Not tested yet.
   backdrop_3.diff (3.7 KiB) 
 apps/onplay.c                         |   15 +++------------
 apps/gui/skin_engine/skin_backdrops.c |   14 +++++---------
 apps/settings.h                       |    2 +-
 apps/settings_list.c                  |    2 +-
 4 files changed, 10 insertions(+), 23 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Sunday, 10 April 2011, 15:18 GMT+2
looks good and quick tes here works, commit it when you can be bothered

Loading...