Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12080 - Scrobbledroid API support for Android

Attached to Project: Rockbox
Opened by Matt Muscari (mgmuscari_) - Monday, 25 April 2011, 09:10 GMT+2
Task Type Patches
Category Music playback
Status Unconfirmed
Assigned To No-one
Player Type Android
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Adding last.fm scrobbling support to the Android version via one of the existing Android Last.fm apps is actually very easy - the log file approach doesn't seem to be compatible with e.g. the actual Last.fm app. Last.fm supports the scrobbledroid api. Adding scrobbledroid intents into the RunForegroundManager class adds support for scrobbling in about 10 lines of code. Attached is a patch to add in the appropriate intent creation and sending. This code could be modified to allow toggling via the settings page, but I don't know much about the native framebuffer code for the UI that is used by rockbox for android. I leave that to somebody else to implement if this is deemed to be too inflexible. I just want to submit this code so that others may enjoy last.fm support without having to jump through hoops to upload log files to last.fm on Android devices.
   mgmuscari.scrobbledroid.patch (1.3 KiB) 
 android/src/org/rockbox/Helper/RunForegroundManager.java |   11 +++++++++++
 1 file changed, 11 insertions(+)

This task depends upon

Comment by Jonas Häggqvist (rasher) - Monday, 25 April 2011, 16:28 GMT+2
I'm not even sure any Rockbox-side code should be added. If you don't want to scrobble with this API, it makes more sense to disable scrobbling in the Android-side scrobbling-app, I'd say?

Now I just hope my currently installed scrobbling app uses this API.
Comment by Matt Muscari (mgmuscari_) - Monday, 25 April 2011, 17:39 GMT+2
That's a good point. FWIW the official last.fm client supports scrobbledroid. As far as I know there are two major scrobbling api's on android. I haven't looked into the other one, but it's probably just as easy to implement.
Comment by Jonas Häggqvist (rasher) - Sunday, 22 May 2011, 17:23 GMT+2
This appears to have stranded in a "everyone wants it to conform to every possible use case" situation.

See from http://www.rockbox.org/irc/log-20110504#09:34:29 and onward.

Loading...