Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12085 - Correction of iap.c to avoid sending useless data to an accessory, and allow larger playlists names

Attached to Project: Rockbox
Opened by Ophir Lojkine (lovasoa) - Thursday, 28 April 2011, 22:31 GMT+2
Last edited by Bertrik Sikken (bertrik) - Saturday, 30 April 2011, 11:17 GMT+2
Task Type Bugs
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch corrects a bit my previous patch, which has yet been committed (http://www.rockbox.org/tracker/task/12079)

It removes an ugly #define I used, and makes use of the standard MAX_PATH instead.
It also send just the needed length when sending a string to the accessory. Before, it sent the entire buffer to the device, whereas now, it stops at the first '\0' (null byte).
   iap_playlist_name_length.patch (2.3 KiB) 
 apps/iap.c |   13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Saturday, 30 April 2011, 11:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as SVN r29796

Loading...