Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12111 - AS3543: Turn off output mixer AGC as done in AMSv1

Attached to Project: Rockbox
Opened by Stephan Grossklass (keyb_gr) - Wednesday, 11 May 2011, 18:52 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Sunday, 24 July 2011, 23:57 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Sansa AMSv2
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

While AMSv1 targets are set up to disable output mixer AGC, this is not done on AS3543 equipped ones for some reason. The provided patch corrects that.

Available headroom does not seem to be changed in digital audio playback.

Two versions are provided, one for a standard Rockbox and another that includes the "audiophile patch"  FS#11304  (some overlap in modified registers there).
   as3543-agc-off-std.diff (1.2 KiB) 
 firmware/export/as3514.h        |    4 ++++
 firmware/drivers/audio/as3514.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

   as3543-agc-off-withfs11304.diff (1.4 KiB) 
 firmware/export/as3514.h        |    4 ++++
 firmware/drivers/audio/as3514.c |    4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Sunday, 24 July 2011, 23:57 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted first patch as r30208. Further discussion for  FS#11304  can continue in its task.
Comment by Martin Sägmüller (dfkt) - Thursday, 19 May 2011, 17:39 GMT+2
I did some RMAA tests on that patch, against a clean default build - results can be seen here: http://anythingbutipod.com/forum/showpost.php?p=554724&postcount=1337
Comment by Sei Aoyumi (Aoyumi) - Saturday, 04 June 2011, 23:07 GMT+2
I tested first patch.
It prevents a change of irregular volume in the music that is very high in mean volume. The patch seems to be surely effective.
Comment by sideral (sideral) - Thursday, 21 July 2011, 22:58 GMT+2
I've been running with this patch (in my case the second patch) for a few weeks without issues. I think it can be committed safely.

Loading...