FS#12132 - tagnavi: Support "basename" in formats and conditions; replace <Untagged> in track views
Opened by sideral (sideral) - Saturday, 28 May 2011, 22:20 GMT
Last edited by sideral (sideral) - Thursday, 04 August 2011, 12:38 GMT
This patch set (in patch 0006) adds support to the tagnavi.config syntax for using a file's basename (path name without directories) in display formats and conditions.
Patch 0007 changes the database's default title format to display a file's basename rather than "<Untagged>" if no title tag is present in the file.
In passing, patch 0001 fixes two bugs introduced with r26192 (
* The translation was done too early: before the tagnavi format clauses were checked. This prevented comparisons against "<Untagged>" when a non-English translation was active.
* The code overwrote the buffer containing the constant string "<Untagged>" with the translation. This is neither safe nor necessary: The result pointer simply can be swapped with a pointer to the translation.
Patches 0002–0005 contain various minor DB cleanups the other patches rely on. (I'll commit the fixes and cleanups separately from the basename feature after some testing.)
Patches relative to r29928.
Thursday, 04 August 2011, 12:38 GMT
Reason for closing: Accepted