Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12165 - Speed up genlang with a generated regex

Attached to Project: Rockbox
Opened by Torne Wuff (torne) - Thursday, 23 June 2011, 00:06 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 08 September 2011, 16:44 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

With this change generating all languages takes only two-thirds the
time. It changes the acceptable syntax for target wildcards in language
files, however: instead of a comma-separated list of glob-style
wildcards it requires that it be a comma-separated list of prefix
matches, i.e. the * can only appear at the end of each wildcard, and ?
cannot be used. This does not require any changes to existing language
files as they are all already in this form.
   0001-Make-genlang-faster-by-doing-better-regexes.... (2.5 KiB) 
 b/tools/genlang |   37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Thursday, 08 September 2011, 16:44 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r30481
Comment by Thomas Martitz (kugel.) - Thursday, 23 June 2011, 01:36 GMT+2
Another problem I spotted with genlang which leads to quite a speedup if fixed.

$BUILD/apps/lang/english.list is some cache file for the english strings. readenglish() is this cache file if it's newer than english.lang. The problem is the cache file is never updated after initial creation, so the fast path in readenglish() is only taken until english.lang is modified. I attach a patch to fix that, resulting in quite a speed up since the the fast path in readenglish() is taken.

Perhaps english.list should be generated via a make rule instead.
   genlang.vc.diff (0.4 KiB) 
 b/tools/genlang |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment by Thomas Martitz (kugel.) - Thursday, 23 June 2011, 01:42 GMT+2
BTW, I have some profiling data here:

http://www.alice-dsl.net/simonemartitz/public/genlang-prof-chin/index.html (SVN)
http://www.alice-dsl.net/simonemartitz/public/genlang-prof-chin-torne/index.html (with the first patch)
http://www.alice-dsl.net/simonemartitz/public/genlang-prof-chin-torne-list/index.html (with both patches)
Comment by Jonas Häggqvist (rasher) - Thursday, 28 July 2011, 01:16 GMT+2
I'll add my +1 to both of these.

Loading...