Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12183 - mpegplayer - add clicks and skip beeps - start new system sounds API

Attached to Project: Rockbox
Opened by Michael Sevakis (MikeS) - Friday, 08 July 2011, 06:14 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 09 July 2011, 00:52 GMT+2
Task Type Patches
Category Video
Status Closed
Assigned To Michael Sevakis (MikeS)
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Adds key sounds like keyclick and track skip beep to mpegplayer since seems like a good place to start using mixer functionality, in a small way, in plugins. Also, consolidates the functionality into a couple common system sounds calls to add ease of use and consistency for plugins. Mpegplayer, as usual, follows core playback settings.
   mpegplayer-key-sounds.patch (13.4 KiB)
 apps/misc.h                          |   22 ++++++++++-
 apps/action.c                        |    4 --
 apps/plugins/mpegplayer/pcm_output.c |   65 ++++++++++++++++++-----------------
 apps/plugins/mpegplayer/mpeg_misc.c  |    4 ++
 apps/plugins/mpegplayer/mpegplayer.c |   26 +++++++++++---
 apps/gui/wps.c                       |    3 -
 apps/playback.c                      |    6 +--
 apps/plugin.c                        |    7 +++
 apps/plugin.h                        |   12 +++++-
 apps/misc.c                          |   48 +++++++++++++++++++++++++
 10 files changed, 149 insertions(+), 48 deletions(-)

This task depends upon

Closed by  Michael Sevakis (MikeS)
Saturday, 09 July 2011, 00:52 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Chucked it in the trunk like a wood chuck would in r30130.

Loading...