Rockbox

Tasklist

FS#12226 - several typo fixes

Attached to Project: Rockbox
Opened by Uwe Kleine-K├Ânig (ukleinek) - Wednesday, 10 August 2011, 09:40 GMT
Last edited by Bertrik Sikken (bertrik) - Friday, 30 December 2011, 15:29 GMT
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

based on trunk@30268
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Friday, 30 December 2011, 15:29 GMT
Reason for closing:  Wont Fix
Comment by sideral (sideral) - Wednesday, 10 August 2011, 15:37 GMT
While in general correct spelling in comments is a laudable goal, fixing spelling has to be weighted against other factors that may speak against touching the code in question at all: The code in question may be imported from a third party and eventually be rebased to a newer upstream version; or, the code may be actively worked on by another developer. In both cases, the spelling fixes create more work (rebasing) for very little benefit, which can be quite annoying. (The same can be said of whitespace fixes or code cleanups.)

Of the files touched by this patch, Doom, GNU chess, and some of the codec libraries belong to the first category; and I think at least elftosb belongs to the second.

Thus, I suggest to not blindly accept this patch, but to use pieces of it at an opportune time.

PS: Also, I don't regard "thru" as a spelling error, especially not in informal code comments.

Loading...