Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12288 - Sansa Clip+: "Home" in the main menu to WPS/Radio

Attached to Project: Rockbox
Opened by Felipe (flaps) - Wednesday, 21 September 2011, 03:31 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Saturday, 25 February 2012, 22:15 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Provides an easy way to access the WPS (or previous music) from the main menu, by pressing home a second time.
This is specifically for the Clip/Clip+, because of its limited number of buttons, so as to keep the ui unaltered for the other players.
   previous_music_from_root.patch (0.5 KiB) 
 apps/menu.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Saturday, 25 February 2012, 22:15 GMT+2
Reason for closing:  Accepted
Comment by Lukas (mfe555) - Saturday, 24 September 2011, 20:09 GMT+2
The topic is being discussed at: http://forums.rockbox.org/index.php/topic,28702.msg184721.html#msg184721
Comment by Akio Idehara (idak) - Thursday, 06 October 2011, 14:42 GMT+2
This patch is what I want!
I vote for it.
Two key combo is too difficult to press with one hand.
Comment by Bertrik Sikken (bertrik) - Tuesday, 11 October 2011, 20:13 GMT+2
I like the idea of this patch, but I think it's better to do this by editing the keymap tables than by adding #ifdefs in the menu code.
Comment by Akio Idehara (idak) - Wednesday, 12 October 2011, 17:32 GMT+2
This patch adds support for selecting Home key role in setting menu.
   select-homekey-role.patch (3.6 KiB) 
 apps/lang/english.lang     |   42 ++++++++++++++++++++++++++++++++++++++++++
 apps/menu.c                |    4 ++++
 apps/settings.h            |    4 ++++
 apps/menus/settings_menu.c |   11 +++++++++++
 apps/settings_list.c       |    7 +++++++
 5 files changed, 68 insertions(+)

Comment by Shiloh Hawley (gree665) - Sunday, 23 October 2011, 01:50 GMT+2
Just got a clip+, and after being annoyed by the impossibility of pressing home+select with one hand, I made a patch for my build to do just this. I was going to submit it here, then I found you guys beat me to it. Good job, thanks!
Comment by Rafaël Carré (funman) - Tuesday, 20 December 2011, 02:12 GMT+2
Please don't add a new setting for this, just enable your key shortcut for everybody.

It looks useful to me, please give a new patch editing the keymap files like bertrik suggested
Comment by Akio Idehara (idak) - Tuesday, 20 December 2011, 16:17 GMT+2
It's the keymap editing version.
   keymap-clip.patch (1.7 KiB) 
 apps/keymaps/keymap-clip.c |   18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Comment by Rafaël Carré (funman) - Tuesday, 20 December 2011, 18:33 GMT+2
The 2 added tables are identical ? (with_combo and without_combo)

Also I don't know if the hold_lr ... setting applies in this case.

Does it?
Comment by Akio Idehara (idak) - Wednesday, 21 December 2011, 13:10 GMT+2
Thank you for commenting.
I simplified the code a bit.
Is it OK?
   keymap-clip-v2.patch (1.2 KiB) 
 apps/keymaps/keymap-clip.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comment by MichaelGiacomelli (saratoga) - Wednesday, 22 February 2012, 22:00 GMT+2
The current version of the patch looks good to me.
Comment by Bertrik Sikken (bertrik) - Thursday, 23 February 2012, 16:13 GMT+2
I'm no keymap code expert, but I very much like the user experience of this patch.
Comment by Rafaël Carré (funman) - Friday, 24 February 2012, 05:15 GMT+2
works for me, please commit it

Loading...