Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12321 - Touchscreen: List line padding, to more easily select lines

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Friday, 07 October 2011, 20:12 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 16:55 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Thomas Martitz (kugel.)
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds line padding to lists on touchscreens, in order to make lists reasonable useful without huge fonts.

It's configurable:
* Automatic (default, line height calculated using a lcd dpi aware function)
* Off (status quo, line height = font height)
* X pixels (from 2 to 50 in even steps)

The automatic setting should/aims to Just Work Out Of The Box on all targets

IMO this patch is needed to make Rockbox on touchscreen/RaaA remotely usable.

Please comment or make suggestions!
   list-line-padding-v1.patch (18 KiB) 
 b/apps/gui/bitmap/list.c               |   36 ++++++++++++++++++++-------------
 b/apps/gui/icon.c                      |    5 ++++
 b/apps/gui/icon.h                      |    3 ++
 b/apps/gui/list.c                      |   34 ++++++++++++++++++++++++-------
 b/apps/gui/viewport.c                  |    3 +-
 b/apps/gui/viewport.h                  |    1 
 b/apps/lang/english.lang               |   31 ++++++++++++++++++++++++++++
 b/apps/menus/display_menu.c            |   13 +++++++++++
 b/apps/settings.h                      |    4 +++
 b/apps/settings_list.c                 |   29 ++++++++++++++++++++++++++
 b/firmware/drivers/lcd-bitmap-common.c |   34 ++++++++++++++-----------------
 b/firmware/export/lcd.h                |    1 
 12 files changed, 153 insertions(+), 41 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Thursday, 22 December 2011, 16:55 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  30773
Comment by zhkailing (zhkailing) - Friday, 14 October 2011, 19:08 GMT+2
Very useful in high-resolution devices.
Comment by zhkailing (zhkailing) - Saturday, 15 October 2011, 14:24 GMT+2
 FS#12321 
Android Device applying this patch cannot show Album Art in notification area.

Bitmap b = BitmapFactory.decodeFile(albumart);
b == null

Loading...