Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12352 - Charger detection for newer Cowon D2+ (pcf50635 equipped)

Attached to Project: Rockbox
Opened by Stanislav Chizhik (anotherche) - Thursday, 27 October 2011, 06:54 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Tuesday, 15 November 2011, 21:39 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type Cowon D2
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The patch solves one of the known problems of newer D2+ listed on CowonD2Info wiki page: "Limited support for players with a PCF50635 power management chip".
The main purpose to make this patch was to use my D2+ in the "car adapter mode". So, the features and details are the following:
1. Insertion and desertion of main or USB charger are detected. The detection is made by monitoring of MBCS1 register of pcf50635.
2. The patch also adds wakeup on charger functionality (it didn't work before because of interrupts masking made in pcf50635 related rockbox code)
3. Onkey1s interrupt handling is added to make shutdown procedure similar to that used for pcf50606 (time-out reset procedure is omitted because OOCMODE register of pcf50635 is configured not to set time-out timer on the onkey1s interrupt in rockbox - wakeup on falling edge only used)

the patch is for revision 29795.
   d2-pcf50635-pwrmon.diff (2.9 KiB) 
 firmware/target/arm/tcc780x/cowond2/power-cowond2.c |   34 ++++++++++++++++++--
 firmware/drivers/pcf50635.c                         |    4 +-
 2 files changed, 34 insertions(+), 4 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Tuesday, 15 November 2011, 21:39 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r30992.

Sorry about the delay, we don't really have anyone maintaining the D2 port these days.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 15 November 2011, 00:27 GMT+2
I'll try and get this committed as soon as someone on the forums can confirm it doesn't break anything on the D2 (non +). Sorry about the delay, but its hard to find people with a D2 to test things.
Comment by Stanislav Chizhik (anotherche) - Tuesday, 15 November 2011, 06:35 GMT+2
No problem, I'm glad to be useful. Let's wait for testers response.

Loading...