Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12390 - Sansa Clip Zip Cabbiev2 Port

Attached to Project: Rockbox
Opened by Stephen Carroll (StephenCarroll) - Thursday, 17 November 2011, 13:13 GMT+2
Last edited by Bertrik Sikken (bertrik) - Sunday, 20 May 2012, 12:23 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type Sansa AMSv2
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Ported from the iRiver H10 5gb version.
Resized icons with The Gimp.

Attched screenshots.

Haven't provided this as a patch because I'm not near my dev machine this week.


Thanks.
   cabbiev2clipzip.zip (15.2 KiB)
   menu.png (5.1 KiB)
   wpsaa.png (6.2 KiB)
   wpsnoaa.png (3.9 KiB)
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Sunday, 20 May 2012, 12:23 GMT+2
Reason for closing:  Accepted
Comment by Bertrik Sikken (bertrik) - Friday, 18 November 2011, 00:02 GMT+2
Looks nice! Some of the icons on the bottom don't appear to be aligned for me though (too high).
Comment by Stephen Carroll (StephenCarroll) - Friday, 18 November 2011, 10:06 GMT+2
Ok I think I have the shuffle icon fixed to line 85. The repeat icon tho on 85 is too low and exposes the background grey of the icon.
See the various screenshots of the various lines I have the repeat icon on and then both icons off. Starting on line 83 then going up to 85.
I think this is the last bit that needs to be fixed.
What line looks the best for the repeat icon ?
   83.png (6.2 KiB)
   84.png (6.2 KiB)
   85.png (6.3 KiB)
   off.png (6.1 KiB)
Comment by Stephen Carroll (StephenCarroll) - Monday, 21 November 2011, 12:08 GMT+2
Ok hopefully this has fixed the icons, it was the wpsbackdrop grey icons that were too high so have fixed them now.
All icons are on line 85, also lowered the lock icon as that appeared too high also.


   cabbiev2clipzip.zip (15.4 KiB)
   wpsnoicons.png (6.6 KiB)
   wpsicons.png (6.7 KiB)
   wpsicons2.png (6.7 KiB)
Comment by Bertrik Sikken (bertrik) - Saturday, 26 November 2011, 12:07 GMT+2
Here's my patch to add this theme as the default theme, which means shuffling files around a bit and adding stuff to WPSLIST.

After a completely fresh install, the clip zip still appears to have everything about the cabbiev2 theme applied (background, colours, wps, selection bar etc.), except for the font. Re-loading the cabbiev2 theme fixes that. The font used after a fresh install appears to be the default specified in apps/settings_list.c.
It appears I don't completely understand the themeing thing yet.
   cabbiev2_clipzip.patch (5.4 KiB) 
 b/backdrops/cabbiev2.96x96x16.bmp       |binary
 b/wps/WPSLIST                           |    5 ++
 b/wps/cabbiev2.96x96x16.wps             |   75 ++++++++++++++++++++++++++++++++
 b/wps/cabbiev2/battery-96x96x16.bmp     |binary
 b/wps/cabbiev2/lock-96x96x16.bmp        |binary
 b/wps/cabbiev2/pb-96x96x16.bmp          |binary
 b/wps/cabbiev2/playmode-96x96x16.bmp    |binary
 b/wps/cabbiev2/repeat-96x96x16.bmp      |binary
 b/wps/cabbiev2/shuffle-96x96x16.bmp     |binary
 b/wps/cabbiev2/volume-96x96x16.bmp      |binary
 b/wps/cabbiev2/wpsbackdrop-96x96x16.bmp |binary
 11 files changed, 80 insertions(+)

Comment by MichaelGiacomelli (saratoga) - Monday, 19 December 2011, 07:15 GMT+2
You also need to tell the settings code which font to default to, since we don't actually load the theme file on startup. I think this will work (untested since I don't have a zip sim handy).

   zipcabbiefont.patch (0.5 KiB) 
 apps/settings_list.c |    3 +++
 1 file changed, 3 insertions(+)

Comment by Xander (xandermac05) - Monday, 02 January 2012, 10:15 GMT+2
Locking the player on the WPS results in the notification of locking popup getting stuck in the background until you leave the screen and come back. Perhaps a minor annoyance, but an annoyance nonetheless. The theme is great, otherwise!
Comment by Stephen Carroll (StephenCarroll) - Tuesday, 03 January 2012, 17:51 GMT+2
That seems to be a problem with other clips aswell. And not just with this theme on the Clip Zip either.
Comment by Michael Rodger (megal0maniac) - Friday, 06 January 2012, 01:16 GMT+2
Confirmed to be a problem on the Fuze+ as well, regardless of the theme, as well as the Clip+.
Both running r31589-120105.
Perhaps an issue with the graphics driver? Re-drawn regions cover the "Buttons Locked" text when the popup disappears, e.g. album art on the Fuze+.
Comment by Bertrik Sikken (bertrik) - Thursday, 29 March 2012, 15:56 GMT+2
Stephen, I've incorporated your work into git (but not in the rockbox git archive yet).
Can you have a look at the changes to the .wps file suggested by Jonathan Gordon in http://gerrit.rockbox.org/r/#/c/197/ ?

Loading...