Rockbox

Tasklist

FS#12411 - Album art not displaying correctly on iAudio x5, verk dark

Attached to Project: Rockbox
Opened by Stephen Carroll (StephenCarroll) - Sunday, 27 November 2011, 19:32 GMT
Last edited by Andree Buschmann (Buschel) - Monday, 19 December 2011, 19:17 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Started the last few days. Very dark album art.
On version r31079-111127

Happens with embedded or with folder.jpg.
Using the picture viewer the art displays correctly, seems to be just in the WPS it looks dark.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Monday, 19 December 2011, 19:17 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with r31366.
Comment by Frank Gevaerts (fg) - Sunday, 27 November 2011, 19:53 GMT
I can reproduce this on my x5, haven't tried other players yet.

I'd say it's not exactly dark, rather wrong. Red and blue seem to be fine (or nearly so anyway), while white is shown as black.

The 3.10 branch doesn't have the problem
Comment by Frank Gevaerts (fg) - Sunday, 27 November 2011, 20:02 GMT
gigabeat f doesn't have this. Maybe related to pixel format?

I'm attaching the file I use to test
Comment by Stephen Carroll (StephenCarroll) - Tuesday, 29 November 2011, 11:17 GMT
Sorry about the quality all I had was my camera phone.
First two shots taken with r31089 then the cover in the image viewer and finally last two in the rc's of 3.10 showing the normal image.
Can also confirm the X5 Panics on screenshot so the only way I could get images was with my camera phone.
Comment by Andree Buschmann (Buschel) - Monday, 19 December 2011, 18:29 GMT
In apps/recorder/bmp.c there is some Coldfire specific assembler code. After reviewing r30938 I saw at least one line of code which might be wrong. The attached patch corrects this.

Loading...