Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12454 - Faster line scroll speed

Attached to Project: Rockbox
Opened by Martin Sägmüller (dfkt) - Thursday, 15 December 2011, 13:19 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Monday, 09 January 2012, 04:26 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Using the smallest/smoothest scroll step size of 1px, I find the fastest scroll speed of 15 to be too slow on some targets, especially those with larger screens.

This patch adds two faster values to scroll speed, it now goes to 17.
   faster_line_scroll_speed.patch (1.8 KiB) 
 apps/settings_list.c     |    4 ++--
 firmware/scroll_engine.c |    6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Monday, 09 January 2012, 04:26 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r31643.
Comment by Alexander Levin (fml2) - Saturday, 17 December 2011, 14:25 GMT+2
Why do the values 2 and 1 correspond to frequencies 41.25 and 51.6? And not 50 and 100? I thought the table is just 1/x.
Comment by Martin Sägmüller (dfkt) - Saturday, 17 December 2011, 15:36 GMT+2
I thought the table pattern is "* 1.25" Hertz - not sure if I added the right values to the comment - I will of course correct it if it's wrong. Good thing it's just a comment, and the 2 and 1 values indeed provide faster scroll speed. :)
Comment by MichaelGiacomelli (saratoga) - Monday, 09 January 2012, 04:26 GMT+2
>> f=fit([100, 80, 64, 50, 40, 32, 25, 20, 16, 12, 10, 8, 6, 5, 4, 3]', [1, 1.25, 1.55, 2, 2.5, 3.12, 4, 5, 6.25, 8.33, 10, 12.5, 16.7, 20, 25, 33]', 'rat01')
f =

General model Rat01:
f(x) = (p1) / (x + q1)
Coefficients (with 95% confidence bounds):
p1 = 100.8 (100.3, 101.3)
q1 = 0.04812 (0.02853, 0.06771)



Loading...