Rockbox

Tasklist

FS#12494 - allow setting the hidden flag on files / folders

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Thursday, 29 December 2011, 14:10 GMT
Last edited by Nils Wallménius (nls) - Saturday, 03 March 2012, 11:42 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch allows setting the hidden flag on files / folders.
CAUTION! Please do not apply this patch if your DAP has imporant data.
I tested this patch, but this patch might have a bug...

All comments are welcome.
This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 03 March 2012, 11:42 GMT
Reason for closing:  Out of Date
Additional comments about closing:  moved to http://gerrit.rockbox.org/r/#/c/152/
Comment by Frank Gevaerts (fg) - Thursday, 29 December 2011, 14:31 GMT
I've quickly looked at the patch, and I have a few comments:

* In apps/plugins/properties.c, I think it's better to add the extra line of output in both dir_properties() and file_properties() instead of in plugin_main(). At least num_properties should be adjusted near that snprintf, instead of "adusting" later on in the call to gui_synclist_set_nb_items() (that's asking for bugs later on).
* Does hide/unhide really need to be able to recurse? I'd assume that people will just hide or unhide the top level directory.
Comment by Akio Idehara (idak) - Tuesday, 28 February 2012, 16:22 GMT

Loading...