Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12494 - allow setting the hidden flag on files / folders

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Thursday, 29 December 2011, 15:10 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 03 March 2012, 12:42 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch allows setting the hidden flag on files / folders.
CAUTION! Please do not apply this patch if your DAP has imporant data.
I tested this patch, but this patch might have a bug...

All comments are welcome.
   hide.patch (20.9 KiB) 
 apps/lang/english.lang      |   56 +++++++++++++++++++
 apps/plugins/properties.c   |   18 ++++--
 apps/onplay.c               |  102 ++++++++++++++++++++++++++++++----
 firmware/export/fat.h       |    1 
 firmware/test/fat/main.c    |   14 ++++
 firmware/include/dircache.h |    1 
 firmware/include/file.h     |    7 ++
 firmware/common/dircache.c  |   31 ++++++++++
 firmware/common/rbpaths.c   |    6 ++
 firmware/common/file.c      |  129 ++++++++++++++++++++++++++++++++++++++++++++
 firmware/drivers/fat.c      |   20 ++++++
 uisimulator/common/io.c     |   10 +++
 12 files changed, 375 insertions(+), 20 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 03 March 2012, 12:42 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  moved to http://gerrit.rockbox.org/r/#/c/152/
Comment by Frank Gevaerts (fg) - Thursday, 29 December 2011, 15:31 GMT+2
I've quickly looked at the patch, and I have a few comments:

* In apps/plugins/properties.c, I think it's better to add the extra line of output in both dir_properties() and file_properties() instead of in plugin_main(). At least num_properties should be adjusted near that snprintf, instead of "adusting" later on in the call to gui_synclist_set_nb_items() (that's asking for bugs later on).
* Does hide/unhide really need to be able to recurse? I'd assume that people will just hide or unhide the top level directory.
Comment by Akio Idehara (idak) - Tuesday, 28 February 2012, 17:22 GMT+2
This task was moved.
http://gerrit.rockbox.org/r/#/c/152/

Loading...