Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#1656 - Enhanced menus + MDB patch (for recorder)

Attached to Project: Rockbox
Opened by Vincent Paeder (cent20) - Monday, 25 August 2003, 16:48 GMT+2
Last edited by Lee Pilgrim (diddystar5) - Sunday, 28 September 2003, 20:07 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Used my widgets there...
   Enhanced menus + MDB.patch (162.7 KiB) 
 rockbox-new/apps/enhanced_menu.c            |  553 +++++++++++++++++++
 rockbox-new/apps/enhanced_menu.h            |   54 +
 rockbox-new/apps/lang/english.lang          |   59 +-
 rockbox-new/apps/main.c                     |   22 
 rockbox-new/apps/menu.c                     |   19 
 rockbox-new/apps/recorder/recording.c       |   63 +-
 rockbox-new/apps/recorder/widgets.c         |  134 ++++
 rockbox-new/apps/recorder/widgets.h         |   14 
 rockbox-new/apps/settings.c                 |  196 ++++--
 rockbox-new/apps/settings.h                 |   24 
 rockbox-new/apps/settings_menu.c            |  805 ++++++++++++++++++----------
 rockbox-new/apps/sound_menu.c               |  352 +++++++++---
 rockbox-new/firmware/drivers/lcd-recorder.c |  194 +++++-
 rockbox-new/firmware/export/lcd.h           |    6 
 rockbox-new/firmware/export/mpeg.h          |    9 
 rockbox-new/firmware/mpeg.c                 |  390 ++++++++-----
 rockbox-new/tools/bmp2rb.exe                |binary
 rockbox-new/tools/convbdf.exe               |binary
 rockbox-new/tools/descramble.exe            |binary
 rockbox-new/tools/generate_rocklatin.exe    |binary
 rockbox-new/tools/scramble.exe              |binary
 rockbox-new/tools/sh2d.exe                  |binary
 22 files changed, 2247 insertions(+), 647 deletions(-)

This task depends upon

Closed by  Zakk Roberts (midkay)
Monday, 19 February 2007, 06:03 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  With all the recent menu changes, new targets, etc. this can be considered out of date/unusable. As for MDB, we\'ve had it in SVN for a couple years now.
Comment by Vincent Paeder (cent20) - Tuesday, 26 August 2003, 21:52 GMT+2

A good looking version. Text is now right aligned when a slider
is present (no more overlap between text and sliders then ...
as far as i know!)
Modified lcd-recorder.c to permit a per pixel scrolling line
positioning (fixes checkbox bug).
Added a new widget ("arrow"). Used in menus to indicate a
list of different values.
Comment by Lee Pilgrim (diddystar5) - Sunday, 28 September 2003, 20:07 GMT+2

I have been playing around with your patch today and I have
a few comments.

1. Could you please remove all the whitespace changes. They
make your patch outdated quicker, and harder to read.

P.S. Could you also fix that on the MDB patch?

2. Try not to include other patches in your patch. I noticed
you included the accurate vbr ff-rew and more directory
sorting options patches.

3. Why is the fade on pause and stop renamed? is dosen't
make any sense when it says "on Pause/Stop"

4. Your patch has some compile errors. Could you please fix
those. Also your patch dosen't compile with the simulator.

5. Could you please post up a patch without the MDB, and
just the menu changes.

Thanks

Loading...