Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#1943 - honor the rva2/xrva/xrv frame

Attached to Project: Rockbox
Opened by Anonymous Submitter - Monday, 19 January 2004, 08:59 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hi,

last friday I received my jukebox recorder 15 and put
rockbox
on it. I did run all my mp3 files through normalize a
couple of month ago. They all have id2.3 tags with an
XRVA frame.
I did not try the code with id1 XRV or id2.4 RVA2 frames.

I put code into rockbox to honor this frame (as good as
possible). Aktually updating the volume is only done for
the recorder.

regards, Matthias (leo@marco.de)
   rockbox.diffs (11.2 KiB)
This task depends upon

Closed by  Daniel Stenberg (bagder)
Saturday, 19 May 2007, 17:26 GMT+2
Reason for closing:  Rejected
Comment by Björn Stenberg (zagor) - Monday, 19 January 2004, 09:38 GMT+2

Why is an RVA tag better than the method mp3gain uses,
which requires no extra player support?
Comment by Anonymous Submitter - Tuesday, 20 January 2004, 10:40 GMT+2

I didn't know about mp3gain. One nice thing about the RVA tag is
that "normalize" doesn't touch the mp3 data at all. And all
my mp3
files already have a RVA tag...

Matthias
Comment by Anonymous Submitter - Tuesday, 20 January 2004, 12:14 GMT+2

And another nice thing about rva is that you can turn it off, if
you wish to listen to a album or track without volume
adjustment.

Matthias
Comment by Blue Chip (bluechip) - Tuesday, 08 June 2004, 05:55 GMT+2

Hi Matthias,

I would like to include this patch in the new Cyborg Systems
branch of Rockbox with all the enhanced audio features.

I would like to do it with your blessing as I think this is a great
audio enhancement.

Bluechip
http://homepage.ntlworld.com/cyborgsystems
Comment by Anonymous Submitter - Friday, 09 December 2005, 21:25 GMT+2

because the method which mp3gain uses cannot be undo-ed,
unless the undo-data is stored somewhere else(i.e. in a tag)
- loose the undo data, and the changes cannot be reversed
anymore.

With a tag-based solution, things are different: if you
loose the tag, then the changes are undo-ed. Thus, there is
no risk for accidental permanent change of the file.
Comment by Mikael Magnusson (mikaelh) - Wednesday, 22 March 2006, 12:36 GMT+2
with a tag you can also have separate album gain and track gain, but i don't know if the mp3 tags let you do that.. ogg does at least.
Comment by Dan Everton (safetydan) - Thursday, 20 July 2006, 13:15 GMT+2
Rockbox on software codec platforms has full Replaygain support using either TXXX tags for ID3v2.3 or RVA2 tags for ID3V2.4. Should we close this patch as it's unlikely that there'll be support for replaygain on hwcodec?
Comment by Jonas Häggqvist (rasher) - Wednesday, 23 August 2006, 02:59 GMT+2
I don't believe it's entirely unlikely. It's certainly possible as the original patch shows (although I belive it might not be quite as fine-grained as the tags suggest, because of hardware limitations).

Loading...