This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#1973 - Onplay added to wps
Attached to Project:
Rockbox
Opened by Henrik Backe (hbacke) - Thursday, 29 January 2004, 17:35 GMT+1
Last edited by Henrik Backe (hbacke) - Wednesday, 17 March 2004, 21:28 GMT+1
Opened by Henrik Backe (hbacke) - Thursday, 29 January 2004, 17:35 GMT+1
Last edited by Henrik Backe (hbacke) - Wednesday, 17 March 2004, 21:28 GMT+1
|
DetailsOnplay is added to wps.
This also enabled several changes in the main_menu. - Create directory moved to onplay, - Browse id3 moved to onplay - Playlist moved to onplay - Bookmarks moved to onplay. - Sleep timer move to the root of the main menu - Mange settings moved to the root of the main menu. playlist_menu.[ch] can be removed. Everything in playlist_menu.c is moved to onplay.c. This patch only "if 0" everything in playlist_menu.c .../Henrik 
onplay.diff
(22.5 KiB)
bookmark.c | 35 ------- bookmark.h | 2 main_menu.c | 99 ++++++++++++++++++--- onplay.c | 251 +++++++++++++++++++++++++++++++++++++++++------------- onplay.h | 2 playlist_menu.c | 2 playlist_viewer.c | 3 screens.c | 13 ++ settings_menu.c | 82 ----------------- tree.c | 4 10 files changed, 301 insertions(+), 192 deletions(-) |
This task depends upon
Closed by Zakk Roberts (midkay)
Monday, 19 February 2007, 06:10 GMT+1
Reason for closing: Out of Date
Additional comments about closing: Seems like most or all of this is already in SVN (context menu for all devices). Anything that isn\'t in SVN now is out of date and probably Recorder-only.
Monday, 19 February 2007, 06:10 GMT+1
Reason for closing: Out of Date
Additional comments about closing: Seems like most or all of this is already in SVN (context menu for all devices). Anything that isn\'t in SVN now is out of date and probably Recorder-only.
Looks good. I'd say we can start using F3 instead of ON+PLAY
on Recorders, in accordance with the NEWKEYS document. (Just
remember players don't have F3, so they will keep ON+PLAY).
I'm thinking about maybe releasing a 2.2 before we commit
the full UI overhaul though.
Ok, I'll do that for both wps and tree browser,
should I also the on+play combo for the recorder ?
.../Henrik
If it's just a few lines of code, keep it for recorder too.
Patch updated with f3 keys. on+play combo kept for the
recorder (very few lines of code).
.../Henrik
Correct version uploaded.
.../Henrik
And a a working version .-)
.../Henrik
Fixed a set_margin bug.
.../Henrik
Updated to latest cvs.
Uses c0utta's context defines so it is a context
sensitive menu. It is not bound to f2 any more
because I have not had time to figure out how to
easily inplement it in the new quickscreen screen.
.../Henrik
Updated to latestcvs.
.../Henrik
Updated to latest cvs.
.../Henrik
Updated to daily cvs
.../Henrik