Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2662 - Show id3 info of file from filetree

Attached to Project: Rockbox
Opened by Mark Arigo (lowlight) - Friday, 02 September 2005, 21:00 GMT+1
Last edited by Peter D'Hoye (petur) - Monday, 13 August 2007, 23:12 GMT+1
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Adds the "Show ID3 Info" menu item to the file context
menu to allow viewing id3 metadata while browsing the
filetree (or playlist). On iriver, select a file and long-press
the joystick to bring up the context menu. I guess it will
also work on achros, but I don't have one.

This also makes modifications to the ID3 info screen to
add spaces between the entries to make it readable.
This is configurable in source with
LINES_PER_ID3_ITEM. It's currently defined as 3 so
there's 1 extra space.

There are two versions of this patch:
v1 applies to the current CVS.
v2 applies on top of patch #1252758 ("Arbitrary vorbis
comments in wps").
   show_file_id3.v2.diff (3.7 KiB)
 onplay.c  |   14 ++++++++++++++
 screens.c |   60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------
 screens.h |    1 +
 3 files changed, 69 insertions(+), 6 deletions(-)

   show_file_id3.v1.diff (5.3 KiB)
 onplay.c  |   14 ++++++++++
 screens.c |   79 ++++++++++++++++++++++++++++++++++++++++++++++++++++----------
 screens.h |    1 
 3 files changed, 82 insertions(+), 12 deletions(-)

This task depends upon

Closed by  Peter D'Hoye (petur)
Monday, 13 August 2007, 23:12 GMT+1
Reason for closing:  Out of Date
Additional comments about closing:  please resubmit synced if possible, and create the patch relative to svn, not alocal directory.
Comment by Mark Arigo (lowlight) - Thursday, 06 October 2005, 21:37 GMT+1

Update 10/6: synced to current cvs.
Comment by Peter D'Hoye (petur) - Thursday, 02 August 2007, 21:40 GMT+1
maybe it would be better to add this to the properties plugin? Just an idea...

Loading...