Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2668 - Bugfixes in iriver pcm record & FM-record on "record" button

Attached to Project: Rockbox
Opened by Toni (ahellmann) - Monday, 05 September 2005, 12:33 GMT+2
Last edited by Toni (ahellmann) - Monday, 31 October 2005, 18:46 GMT+2
Task Type Patches
Category
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch includes 2 major bugfixes in pcm_record.c
and allows radio recording on record button for iriver
H1xx.

New iriver FM recording feature:
1. direct FM recording with 'record' button ('off' button to
stop recording). Recordings are saved in '/recordings'.

Not yet done:
1. No continues multiple records
So do not press: record->record->record but press:
record->off->record->off

Bugfixes:
1. avoid audio glitch at recording startup
old pcm_record.c: DAR1 = (unsigned long)rec_buffers
[write_index++];
new pcm_record.c: DAR1 = (unsigned long)rec_buffers
[write_index];

2. avoid audio lock after recording (no reboot neccessary)
old pcm_record.c: pcm_close_recording() not serialized
new pcm_record.c: pcm_close_recording() serialized
   fmrecord.patch (14.7 KiB) 
 rockbox-patched/apps/misc.c                  |   44 +++++++++++++++
 rockbox-patched/apps/recorder/radio.c        |   55 ++++++++++++++++---
 rockbox-patched/apps/recorder/recording.c    |   52 ++----------------
 rockbox-patched/apps/recorder/recording.h    |    2 
 rockbox-patched/build                        |only
 rockbox-patched/build_h100                   |only
 rockbox-patched/build_h100_sim               |only
 rockbox-patched/build_ondio                  |only
 rockbox-patched/build_ondio_sim              |only
 rockbox-patched/build_sim                    |only
 rockbox-patched/buildd                       |only
 rockbox-patched/docs/CREDITS                 |    1 
 rockbox-patched/firmware/pcm_record.c        |   77 +++++++++++++++------------
 rockbox-patched/tools/bmp2rb.exe             |only
 rockbox-patched/tools/convbdf.exe            |only
 rockbox-patched/tools/descramble.exe         |only
 rockbox-patched/tools/descramble.o           |only
 rockbox-patched/tools/generate_rocklatin.exe |only
 rockbox-patched/tools/iaudio.exe             |only
 rockbox-patched/tools/iaudio.o               |only
 rockbox-patched/tools/iriver.o               |only
 rockbox-patched/tools/mkboot.exe             |only
 rockbox-patched/tools/rdf2binary.exe         |only
 rockbox-patched/tools/scramble.exe           |only
 rockbox-patched/tools/scramble.o             |only
 rockbox-patched/tools/sh2d.exe               |only
 26 files changed, 142 insertions(+), 89 deletions(-)

This task depends upon

Closed by  Michael Sevakis (MikeS)
Tuesday, 07 November 2006, 00:47 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  :)
Comment by Anonymous Submitter - Friday, 14 October 2005, 03:06 GMT+2

is it possible to add the peak meter to the next patch?
Comment by Toni (ahellmann) - Friday, 14 October 2005, 17:52 GMT+2

I personally don't like the peakmeter in the radio screen for
the reason that the radio input signal can get disurbed by
some electronic interference caused by the peakmeter.
Beside this it would be relatively easy to add the peakmeter
functionality. When I have time I will continue on this patch.
Comment by Dave Drury (sourcemedd) - Monday, 31 October 2005, 11:36 GMT+2

I have installed this patch but am not able to listen to
anything recorded (either with FM or line in, mic as the
source). THe recordXX.wav file doesn't play on iriver or
PC. Any tips??
Comment by Toni (ahellmann) - Monday, 31 October 2005, 18:46 GMT+2

Did you use a daily build from 20050905? If not, then I guess
there might be conflicts with current builds, since there have
been done a lot of modifications to the code. Because this
patch does not completely integrate into the rockbox source,
there is no chance for CVS commitment. So I lost interest in
updating to the current builds. :-(

Loading...