Rockbox

Tasklist

FS#2677 - independent visible selection for the statusbar

Attached to Project: Rockbox
Opened by Stephan Wezel (thewolfwillcome) - Monday, 12 September 2005, 22:14 GMT
Last edited by Stephan Wezel (thewolfwillcome) - Sunday, 20 November 2005, 17:38 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I have made a little patch to select when the statusbar
will be visible.
With this patch you must change two settings to archive:
Statusbar both, WPS only, Browser only

I have only updated the english.lang file to reflect
the additional setting.

Real Name: Stephan Wezel

PS: Could some of the admins please delete the same
patch report from anonymouse. I had forgotten to login
while summiting the patch.
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Saturday, 26 August 2006, 12:15 GMT
Reason for closing:  Out of Date
Additional comments about closing:  the discussed wps tag has been implemented (as discussed in the comments)
Comment by Jonas Häggqvist (rasher) - Monday, 12 September 2005, 22:26 GMT

Why the need for two options? Why not just have the option
be a 4-choice one?

Off
Always on
WPS only
Browser only
Comment by Stephan Wezel (thewolfwillcome) - Monday, 12 September 2005, 23:49 GMT

this is my first one ;) I must decover how a multiple choice
works ;) then i can reduce the two options to one
Comment by Jonas Häggqvist (rasher) - Monday, 12 September 2005, 23:57 GMT

Fair enough. To be honest, I have no idea myself. Look
around other similar options and see how it works is all the
advice I have to offer.
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 13 September 2005, 01:11 GMT

So here the new patch with an 4-choice option ensteed the 2
seperate one in the first patch
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 13 September 2005, 04:02 GMT

I think a better solution would be to have a WPS tag that
could control the status bar. Then there wouldn't be a need
for an extra option.
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 13 September 2005, 07:58 GMT

Ok i have added the WPS tag "%we"(enable statusbar) and
"%wd"(disable statusbar) to override the global statusbar
setting.

Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 13 September 2005, 09:27 GMT

I think the statusbar 4-option setting is unnecessary with
the WPS tag addition. Also, I think the wps_statusbar flag
shouldn't be in the global_settings struct.
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 13 September 2005, 10:27 GMT

Ok Owk now with original statusbar option(on/off) and only
the 2 wps-tags

I leave the other patches for someone who whant the 4-choice
option :)
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 13 September 2005, 10:38 GMT

It would be nice if the patch file only contained the
relevant changes.
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 13 September 2005, 11:14 GMT

so patch cleaned up as far as possible
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 13 September 2005, 11:31 GMT

Why have you changed all status_draw(xxx) calls to

if(global_settings.statusbar)
status_draw(xxx);

in so many files?

Also, don't use TAB when indenting the code.
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 13 September 2005, 13:07 GMT

I had to change it, because without the change it wouldn't work.

Now i have a other way to ensure that it works.

I hope that this pleases you better
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 13 September 2005, 15:33 GMT

oh in the patch was a failure, now fixed
Comment by Stephan Wezel (thewolfwillcome) - Wednesday, 14 September 2005, 16:23 GMT

new version, now it works correctly, when leaving the menu,
which can be accessed by holding the select-button(iriver)
in WPS-Screen
Comment by Stephan Wezel (thewolfwillcome) - Saturday, 17 September 2005, 20:39 GMT

v3: code cleanup
Comment by Jonas Häggqvist (rasher) - Monday, 26 September 2005, 14:02 GMT

This patch seems to have a bug.

If I have a WPS with no %wd or %we, it defaults to statusbar
off, it seems. It should default to whatever the current
setting is.
Comment by Stephan Wezel (thewolfwillcome) - Monday, 26 September 2005, 18:45 GMT

i have solved the bug.
Comment by Stephan Wezel (thewolfwillcome) - Tuesday, 27 September 2005, 12:43 GMT

oh i forgotten a semicolon :)
Comment by Stephan Wezel (thewolfwillcome) - Friday, 18 November 2005, 14:45 GMT

updated to the new wps-widget
Comment by Stephan Wezel (thewolfwillcome) - Sunday, 20 November 2005, 16:02 GMT

some minor changes to decrease code-duplications and use a
function instead

and removed the old obsolete patches
Comment by Stephan Wezel (thewolfwillcome) - Sunday, 20 November 2005, 16:51 GMT

some more duplicated code converted into a function
Comment by Stephan Wezel (thewolfwillcome) - Sunday, 20 November 2005, 17:38 GMT

bug fixed: statusbar wasn't shown in wps when %we was given
in wps-file and the statusbar-setting was off

Loading...