Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2855 - My mods to 1374953 to make it work on my h340 with non-lcd-r

Attached to Project: Rockbox
Opened by perplexity (bkc1974) - Wednesday, 21 December 2005, 20:33 GMT+2
Last edited by perplexity (bkc1974) - Saturday, 24 December 2005, 17:27 GMT+2
Task Type Patches
Category
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version Unstable (example)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is patch 1374953 hacked to work with a non-lcd
remote on my h340.

The changes to gwps-common.c and gwps.c were causing
all sorts of headaches stopping the key mapping from
working correctly on my unit.

In addition, it was not loading the remote type on
startup and was defaulting to the H100-LCD remote.

Plus the HOLD switch now works

Cheers to tfact for the original :)
   remote-select-3.patch (14 KiB) 
 apps/settings.c           |    2 
 apps/settings.h           |    1 
 apps/settings_menu.c      |   14 ++++
 apps/tree.c               |   13 ++++
 apps/tree.h               |    3 +
 apps/gui/gwps-common.c    |    1 
 apps/lang/english.lang    |   33 +++++++++++
 firmware/drivers/button.c |  138 +++++++++++++++++++++++++++-------------------
 firmware/export/button.h  |   11 +++
 9 files changed, 160 insertions(+), 56 deletions(-)

   remote-select-3.patch (14 KiB) 
 apps/settings.c           |    2 
 apps/settings.h           |    1 
 apps/settings_menu.c      |   14 ++++
 apps/tree.c               |   13 ++++
 apps/tree.h               |    3 +
 apps/gui/gwps-common.c    |    1 
 apps/lang/english.lang    |   33 +++++++++++
 firmware/drivers/button.c |  138 +++++++++++++++++++++++++++-------------------
 firmware/export/button.h  |   11 +++
 9 files changed, 160 insertions(+), 56 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Friday, 03 November 2006, 09:24 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  The hxxx remotes are supported in cvs so this is no longer needed
Comment by Linus Nielsen Feltzing (linusnielsen) - Friday, 23 December 2005, 01:44 GMT+2

It would be nice if you attached the patch as well.
Comment by perplexity (bkc1974) - Saturday, 24 December 2005, 15:45 GMT+2

Hrm.. I'm obviously having trouble getting this uploaded.

Just tried this against a h300 LCD remote also and the key
mapping is very wrong. I have access to both h300 lcd and
non-lcd remotes until 28th of Dec so I'll try to get it
working. h300 non-lcd still works well.
Comment by perplexity (bkc1974) - Saturday, 24 December 2005, 17:27 GMT+2

Hrm.. I'm obviously having trouble getting this uploaded.

Just tried this against a h300 LCD remote also and the key
mapping is very wrong. I have access to both h300 lcd and
non-lcd remotes until 28th of Dec so I'll try to get it
working. h300 non-lcd still works well.

Loading...