Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2974 - "album artist" ID3 tag support

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Wednesday, 01 February 2006, 23:03 GMT+1
Last edited by Nicolas Pennequin (nicolas_p) - Thursday, 06 April 2006, 23:52 GMT+1
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This is a very simple patch to add an album artist tag to the WPS.
I've been using it for quite some time and thought it might be useful to others so i decided to post it here.
This tag is common in foobar and is very useful to distinguish albums with various artists (see http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Encouraged_Tag_Standards#ALBUM_ARTIST for more info).
   album_artist_v2.patch (3.4 KiB) 
 apps/gui/gwps-common.c |    3 +++
 apps/lang/english.lang |    5 +++++
 apps/metadata.c        |    4 ++++
 apps/screens.c         |    1 +
 firmware/export/id3.h  |    1 +
 firmware/id3.c         |    1 +
 6 files changed, 15 insertions(+)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Saturday, 10 February 2007, 13:25 GMT+1
Reason for closing:  Duplicate
Additional comments about closing:  superceded by  FS#6638 
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 01 February 2006, 23:12 GMT+1

sorry, forgot to mention the new WPS tag for album artist is %ip

Also i'd like to add this field to the "show ID3 info"
screen, so that will probably come when i have time to look
at it.
Comment by Nicolas Pennequin (nicolas_p) - Monday, 06 February 2006, 22:52 GMT+1

new version (v2) :
added the album artist info to the "show ID3 info" screen
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 04 April 2006, 17:42 GMT+1
upadated for the current CVS (langv2 broke it)
(application/octet-stream)    album_artist_20060404.patch (3.6 KiB) 
 apps/gui/gwps-common.c |    3 +++
 apps/lang/english.lang |   14 ++++++++++++++
 apps/metadata.c        |    4 ++++
 apps/screens.c         |    1 +
 firmware/export/id3.h  |    1 +
 firmware/id3.c         |    1 +
 6 files changed, 24 insertions(+)

Comment by Ruben Petersen (Luckz) - Tuesday, 25 April 2006, 15:52 GMT+1
How about incorporating the functionality of this (ALBUM ARTIST/ALBUM_ARTIST) and http://www.rockbox.org/tracker/task/4961 plus support for DISC TITLE/DISC_TITLE tags into one patch? I don't know in how far the spaces in %ALBUM ARTIS% and %DISC TITLE% as proposed by the foobar wiki ( http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Encouraged_Tag_Standards ) could be a problem across platforms.
Comment by Ryan Sawhill (ryran) - Tuesday, 04 July 2006, 03:14 GMT+1
Btw, for anyone that's trying to use this: it doesn't work for mp3 files for some reason. Nicolas knows about it. He says it DOES work as intended for ogg files.

Loading...