Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#2999 - Reads USLT Lyrics from id3->txt file displays with viewer

Attached to Project: Rockbox
Opened by David Bleakley (cool2bdave) - Wednesday, 08 February 2006, 03:13 GMT+2
Last edited by Frank Gevaerts (fg) - Monday, 15 December 2008, 23:56 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Sorry for the repeat I was not logged in
Reads USLT Lyrics from id3->txt file displays with
viewer
when an mp3 is playing, hold down play, choose show
lyrics.

This then reads the USLT lyrics from an id3 file
(media player,musicmatch, realplayer etc)

The text is copied to a text file in .rockbox

The viewer is called to display it.
   Lyrics.zip (41.1 KiB)
This task depends upon

Closed by  Frank Gevaerts (fg)
Monday, 15 December 2008, 23:56 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  This looks outdated. If it does get more updates, please open a new task
Comment by David Bleakley (cool2bdave) - Tuesday, 28 February 2006, 01:03 GMT+2
Taken a while to work out patches. This patch does what Lyrics.zip does for the most recent build.

My next plan is to try to use wps to store lyrics in a 2D array: a line of lyrics and a time stamp. I would still like to keep using the txt viewer method though.
   lyrics.patch (25.8 KiB) 
 apps/lang/english.lang |    8 +-
 apps/onplay.c          |   52 +++++++-------
 apps/screens.c         |   21 +++++
 apps/screens.h         |    5 -
 firmware/export/id3.h  |    7 +
 firmware/id3.c         |  180 ++++++++++++++++++++++++++++++-------------------
 6 files changed, 172 insertions(+), 101 deletions(-)

Comment by David Bleakley (cool2bdave) - Monday, 18 September 2006, 20:42 GMT+2
I have not been working on this as I have been waiting for the audio buffer to be structured to enable extra data to be stored before the audio data. I am not sure of the progress of the audio buffer.
Comment by David Bleakley (cool2bdave) - Thursday, 02 August 2007, 02:34 GMT+2
I am still keen to implement this once buffered meta data is up and running

See:
http://www.rockbox.org/twiki/bin/view/Main/MetadataOnBuffer
Comment by shiloh (gree665) - Monday, 24 September 2007, 15:45 GMT+2
Hi I have USLT lyrics in my mp3 collection, I would love to have a way to view 'em. I realize you are waiting for the metadata stuff to make more changes, but could you update your patch in the meantime? I would be grateful...
Comment by Frank Gevaerts (fg) - Saturday, 13 December 2008, 19:34 GMT+2
I think this should be closed. If I don't get any reason why not to close, I'll close this in the next few days

Loading...