This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#3058 - working rockbox with button for iPod 3G
Attached to Project:
Rockbox
Opened by slimx (slimx) - Wednesday, 22 February 2006, 22:21 GMT+2
Last edited by mike (ssnajper) - Thursday, 23 February 2006, 04:54 GMT+2
Opened by slimx (slimx) - Wednesday, 22 February 2006, 22:21 GMT+2
Last edited by mike (ssnajper) - Thursday, 23 February 2006, 04:54 GMT+2
|
Detailstry it and smile :)
|
This task depends upon
Closed by Dave Chapman (linuxstb)
Saturday, 17 February 2007, 03:46 GMT+2
Reason for closing: Accepted
Additional comments about closing: This code must have been committed in the past...
Saturday, 17 February 2007, 03:46 GMT+2
Reason for closing: Accepted
Additional comments about closing: This code must have been committed in the past...
Thanks for your unbelievable work slimx!
Can you please get this added to cvs and make a 3g
bootloader so it will be more simple to install? (with a
seperate daily builds for 3g)
Thanks a ton once again!
but i agree mike it will be much simpler to install and try.
you can find my bootloader here and i'll add my current rockbox.zip
so it will be easy for users .....
1) Firstly, some cosmetic issues - the patch makes a lot of white-space changes to existing files),including adding TAB characters (which aren't allowed in the Rockbox source). Also, your use of white space isn't consistent,- e.g. sometimes you use two spaces either side of an ||, and sometimes none.
2) The diff to pcm_playback.c creates a duplicate of what looks like an old (i.e. buggy) version of the WM8975/WM8758 code. This shouldn't be necessary - you should be able to use (by defining the appropriate macros, or adding a small number of #ifdefs) the existing code without needing to create a copy of it (but I realise the audio driver is still in the early stages).
it's done against current cvs and would build cleanly (i've tested it in a new fresh cvs directory)
I've removed pcm_playback code as Dave have done in current cvs.