Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4721 - add interface to get absolute touch wheel value and use in brickmania (ipod 4g/nano)

Attached to Project: Rockbox
Opened by Mikael Magnusson (mikaelh) - Friday, 24 February 2006, 09:50 GMT+2
Task Type Patches
Category
Status Closed
Assigned To No-one
Player Type iPod Nano
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

well, what the summary says i guess. There are many things to improve here, maybe stop sending the scroll events or add a function to let plugins enable/disable them (suggested by someone on irc).
   rockbox-wheel-absolute.patch (2.9 KiB) 
 firmware/drivers/button.c |    9 +++++++++
 firmware/export/button.h  |    1 +
 apps/plugin.c             |    5 ++++-
 apps/plugin.h             |    5 ++++-
 4 files changed, 18 insertions(+), 2 deletions(-)

This task depends upon

View Dependency Graph

Closed by  Dave Chapman (linuxstb)
Tuesday, 26 September 2006, 21:32 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committd to CVS, thanks.
Comment by Mikael Magnusson (mikaelh) - Friday, 24 February 2006, 09:52 GMT+2
i implemented it so either half of the wheel can be used to control the pad, since it's weird to move the finger left to get the pad to the right. The *8/6 part is so the zone between the halves put the pad at the edge. Halves being the upper and lower half, not left and right. I also couldn't resist changing those two assignments in the second to last two hunks.
   rockbox-brickmania-absolute-wheel.patch (3.7 KiB) 
 apps/plugins/brickmania.c |   40 ++++++++++++++++++++++++++++------------
 1 file changed, 28 insertions(+), 12 deletions(-)

Comment by Mikael Magnusson (mikaelh) - Friday, 17 March 2006, 02:04 GMT+2
and pacbox, depends on new version coming soon
   rockbox-pacbox_absolute_wheel.patch (1 KiB) 
 pacbox.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comment by Mikael Magnusson (mikaelh) - Friday, 17 March 2006, 02:24 GMT+2
now is an int, probably more efficient. returns -1 when wheel isn't touched.
   rockbox-wheel_absolute_patch_v2.patch (3.6 KiB) 
 apps/plugin.h             |    5 ++++-
 apps/plugin.c             |    5 ++++-
 firmware/drivers/button.c |   12 ++++++++++++
 firmware/export/button.h  |    3 +++
 4 files changed, 23 insertions(+), 2 deletions(-)

Comment by Mikael Magnusson (mikaelh) - Friday, 17 March 2006, 02:52 GMT+2
added wheel_send_events(bool send) to enable/disable sending of events, also ensure events are enabled when leaving a plugin.
   rockbox-wheel_absolute_patch_v3.patch (4.7 KiB) 
 apps/plugin.c             |   11 ++++++++++-
 apps/plugin.h             |    6 +++++-
 firmware/drivers/button.c |   20 +++++++++++++++++++-
 firmware/export/button.h  |    4 ++++
 4 files changed, 38 insertions(+), 3 deletions(-)

Comment by Mikael Magnusson (mikaelh) - Friday, 17 March 2006, 15:32 GMT+2
updated pacbox to not hang in the menu due to disabled scroll events.
   rockbox-pacbox_absolute_wheel_v2.patch (1.9 KiB) 
 apps/plugins/pacbox/pacbox.c |   25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

Comment by Brandon Low (lostlogic) - Saturday, 18 March 2006, 22:25 GMT+2
Can you adapt this to work with the interface I've just put in place to report position information with wheel events (might need to add a method to get a full button event from the button queue, but it should be doable).

Sorry I didn't look for this before doing what I was, but I believe that sending the wheel data as part of the button event is preferable if it will work for your needs as well.

Thanks for the patches.
Comment by Mikael Magnusson (mikaelh) - Sunday, 19 March 2006, 17:08 GMT+2
here's an updated patch.
   rockbox-wheel_absolute_patch_v4.patch (3.3 KiB) 
 firmware/drivers/button.c |   32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

Comment by Anton Romanov (theli) - Saturday, 15 April 2006, 11:38 GMT+2
this may be strange ... but with this patch shutdown by holding play/pause is not working for me on iPod Mini ...
while playback stop by holding the same works ...
Comment by Anton Romanov (theli) - Saturday, 15 April 2006, 11:40 GMT+2
oh.. i'm stupid ... ptch changes it to play+select... sorry

Loading...