Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4747 - Delete Presets

Attached to Project: Rockbox
Opened by Manuel Dejonghe (limbus) - Tuesday, 28 February 2006, 12:24 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch allowes presets to be deleted.
It has a new string for the context menu entry.
(application/octet-stream)    radio.patch (2.6 KiB)
 radio.c |   73 ++++++++++++++++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 58 insertions(+), 15 deletions(-)

(application/octet-stream)    radio.u.patch (4.4 KiB)
 radio.c |   73 ++++++++++++++++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 58 insertions(+), 15 deletions(-)

(application/octet-stream)    english.patch (0.3 KiB)
 english.lang |    6 ++++++
 1 file changed, 6 insertions(+)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Tuesday, 06 March 2007, 22:23 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  heavily out of date, and as far as I know most of the functionality is already implemented. If there is something missing (and someone is still interested in this) feel free to open a new task for that.
Comment by Manuel Dejonghe (limbus) - Thursday, 02 March 2006, 12:57 GMT+2
Please, excuse my dohness.
I discovered the preset list menu with the action "delete" "hidden" behind the navi-key.

Nonetheless, the patch is not yet completely pointless. If somebody cares, I will strip it down to the following feature:
pressing left or right in preset mode switches automatically to scan mode if there is less than 2 presets.
Comment by Manuel Dejonghe (limbus) - Wednesday, 08 March 2006, 02:24 GMT+2
Hi,
I am bringing down this patch to something else. It's the remainder of this patch and the other one that got already commited.
It contains:
- Some detabbing
- Some correction concerning the loops going through the presets (num_presets instead of MAX_PRESETS)
- Some comments to #endifs
- The mode cannot be changed to preset if there are not at least two presets.

~lImbus
(application/octet-stream)    radio.patch (1.3 KiB)
 radio.c |   31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

(application/octet-stream)    radio.u.patch (2.4 KiB)
 radio.c |   31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

Comment by Eddy (bascule) - Tuesday, 06 March 2007, 21:39 GMT+2
Close this, as it does not appear to do anything and will be well out of sync with SVN?

Loading...