Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4780 - EQ WPS tags

Attached to Project: Rockbox
Opened by Ben Keroack (bk) - Sunday, 05 March 2006, 22:43 GMT+1
Task Type Patches
Category WPS
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Adds support for displaying EQ settings in the WPS.

Creates the following new tags:

%eq - "1" if EQ is enabled, "" if disabled
%e1 - Band 0 (Low Shelf, 60 Hz)
%e2 - Band 1
%e3 - Band 2
%e4 - Band 3
%e5 - Band 4 (High Shelf, 12 kHz)

The band tags are set in the following steps:

tag value band gain (db)
0: < -9.1
1: -9 - -6.1
2: -6 - -3.1
3: -3 - 0.1
4: 0
5: 0.1 - 3
6: 3.1 - 6
7: 6.1 - 9
8: > 9.1

This allows WPS designers to create graphical representations of the current EQ settings.
   eq-wps.patch (2.8 KiB)
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Friday, 13 April 2007, 17:21 GMT+1
Reason for closing:  Rejected
Comment by Ben Keroack (bk) - Sunday, 05 March 2006, 23:02 GMT+1
Slightly better error handling
   eq-wps-v1.1.patch (2.8 KiB)
Comment by Ben Keroack (bk) - Tuesday, 14 March 2006, 16:14 GMT+1
After some thought I've decided this design is basically broken. It would take 40 bitmaps for a decently functional EQ display which is just too many considering the 52 bitmap limit.

This would be better implemented as a hard-coded widget (similar to the progress bar).

Loading...