Warning: mysqli_real_connect(): Headers and client library minor version mismatch. Headers:50625 Library:50543 in /sites/rockbox.org/flyspray/adodb/drivers/adodb-mysqli.inc.php on line 108 FS#4812 : Add 'Delete'-Entry to WPS-Onplay Menu



FS#4812 - Add 'Delete'-Entry to WPS-Onplay Menu

Attached to Project: Rockbox
Opened by Christian Marg (einhirn) - Friday, 10 March 2006, 08:48 GMT
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 31 July 2007, 12:52 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No


I often want to delete the Track I'm just listening to, so this is an easy way to do it... Tested on JBRv1 only, but should work on other platforms as well, since nothing funky is done...
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 31 July 2007, 12:52 GMT
Reason for closing:  Duplicate
Comment by tim e (timecop) - Monday, 11 September 2006, 04:28 GMT
yes, what a great idea
is there any particular reason this hasn't been merged into cvs?
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 11 September 2006, 05:55 GMT
Two reasons:

1) Fear of accidental deletion (not really a compelling reason)

2) There are issues with the playback engine when deleting the currently playing track.
Comment by tim e (timecop) - Monday, 11 September 2006, 05:57 GMT
clearly, if the user selected this option they already know they want to delete the file.
how is this different from deleting from fileview anyway.
waht issues with deleting playing track? i wanst able to notice any
Comment by Pileot (Pileot) - Wednesday, 16 May 2007, 23:41 GMT
This would be a great addition. Perhaps when somone selected to delete a file there could be a confirmation so there were no accidental file deletions, and perhaps if there were a "recycle bin" of sorts where you could undelete the file if you later realized you wanted it at a later time, but files in this "recycle bin" would not be playable. I know often i listen to a song and want to remove it from my player, but when i get to a computer i forget which song it was i wanted to remove.

Either way, im sure a workaround could be made for issues with the playback engine...

I look forward to this being part of Rockbox
Comment by Christian Marg (einhirn) - Thursday, 17 May 2007, 07:48 GMT
In fact, there already is a confirmation screen when I want to delete a file.

Issues with the playback engine: On my JBR I only found that skipping back instead of forward on having deleted a file, the playback stops for a while. I pressed skip forward and/or backwards again and playback resumed.

Perhaps one could switch to the next track after deleting the current automatically?

(Hmm - I should check if the patch still applies to current sources in SVN... Will look into it someday soon)
Comment by Baffo (Il_Baffo) - Thursday, 28 June 2007, 10:08 GMT
I also think it's a great idea.
It could be done by choosing delete from the contextual menu and accepting the confirmation dialog,
after that the player could skip to the next track and, only after that, there are two possibilities:
-delete the file as in normal file browsing
-move the file to a special directory in .rockbox folder named "trash" or something like that
maybe all two options can be done by adding a preference in system menu called like "delete mode" giving that options.
It's not confortable to skip the track and search for it in the file browser.

(Excuse my bad english)