Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#4817 - Remove duplicated scrolling code in the LCD drivers.

Attached to Project: Rockbox
Opened by Fredrik Öhrn (ohrn) - Saturday, 11 March 2006, 18:03 GMT+1
Task Type Patches
Category Drivers
Status Unconfirmed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch merges the scrolling code from all the bitmap LCD drivers (except the H100 remote) into a single file.
The copyright notice needs to be fixed, I was unable to figure out from whom the scrolling code actually originated.
(application/octet-stream)    remove_duplicate_scrolling.di... (32.1 KiB)
This task depends upon

Comment by pillo (pillo79) - Saturday, 11 March 2006, 19:08 GMT+1
It seems you forgot to include in the patch the scrolling.c file you just created. This is probably because you used "cvs diff" on a tree with non-yet-added cvs files (see first line of your .diff ;-)
Comment by Fredrik Öhrn (ohrn) - Saturday, 11 March 2006, 19:23 GMT+1
Doh! I spent ages fighting with cvs over that misfeature and then I manage to upload the wrong file.
Here's the correct diff with scrolling.c included.
(application/octet-stream)    correct_patch.diff (39.8 KiB)
Comment by Fredrik Öhrn (ohrn) - Monday, 13 March 2006, 10:45 GMT+1
OK, I managed to leave some junk in a function declaration. Here's a new patch.
(application/octet-stream)    correct_patch2.diff (39.8 KiB)
Comment by Jonathan Gordon (jdgordon) - Tuesday, 31 July 2007, 15:26 GMT+1
quick attempt to merge the bits of the lcd drivers which wernt done last week.
untested because stupid gcc complains about no sysfont.h with this, hopefully someone else has more luck
   lcd_update.diff (23.1 KiB)
Comment by Peter D'Hoye (petur) - Thursday, 02 August 2007, 23:14 GMT+1
Jonathan?
Comment by Jonathan Gordon (jdgordon) - Saturday, 11 August 2007, 16:56 GMT+1
forgot about this one...

something causes sysfont.h to not be created...
Comment by Barry Wardell (barrywardell) - Saturday, 11 August 2007, 17:29 GMT+1
The problem isn't really with sysfont.h. The problem is your change in firmware/SOURCES. The added line should be 'drivers/lcd-generic.c'. For some reason, whenever a file from SOURCES doesn't exist, we get an error about sysont.h not being created instead of an error about the missing file.

I made the change to firmware/SOURCES, but there are a load of errors in compiling lcd-generic.c so I didn't go any further with testing it.

Edit: I've opened a task for the sysfont.h problem and added it as a related task here.
Comment by Jonathan Gordon (jdgordon) - Sunday, 12 August 2007, 02:38 GMT+1
doh, thanks Barry.

here is a partial sync.. it now compiles fine on 16 bit non-lcd-remote targets.. if this is wanted the rest of the lcd targets can be fixed up also
   lcd_update.diff (25.7 KiB)

Loading...