- Status Closed
- Percent Complete
- Task Type Bugs
- Category Utils
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.0
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#4831 - Change web server mime type for .diff
Files with a .diff extention are sent as octet stream, changing it to text/plain instead makes quick inspection of patches much easier.
Closed by mcuelenaere
2009-12-15 11:53
Reason for closing: Works For Me
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-12-15 11:53
Reason for closing: Works For Me
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
This seems to be resolved.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
It doesn't actually set octetstream automatically, it assignes different mime types depending on the contents of the file.
I agree it's an annoying behaviour (excarbated strongly by Firefox' lack of "view in browser") but I currently don't know how to fix it. (Did a quick peek in the flyspray source but couldn't find where it's figuring out the type.)
OK, I figured it out. Flyspray takes the mime type supplied by the uploading browser and sticks it into the database (scripts/modify.php, line 1175). When someone downloads the file it blindly sends the stored mime type (index.php lines 102-130).
Since most browsers know jack shit about the file they are uploading they play is safe and send application/octet-stream.
It'll require some major surgery ro fix this silly behaviour, I guess I'll just have to go to Flyspray's site and complain loudly…
Well, associating .diff with text files didn't help, Firefox still uploads them as a binary file.
/me pokes Bjorn
so this is now a battery/charging issue? Great!
Fun! The change was actually from Feature Request to Bug so that it wasn't lost in the sea, and there's no category for Flyspray-related items.
Isn't this solved now?
I haven't seen any new diffs with the wrong mime type lately..