Rockbox

Tasklist

FS#4988 - Optionally keep backlight on while plugins are running

Attached to Project: Rockbox
Opened by Paul van der Heu (paulheu) - Saturday, 01 April 2006, 17:11 GMT
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 31 July 2007, 12:54 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch will add an option to General settings/Display/LCD settings to keep backlight on when using plugins

My first patch, so be gentle.. :)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 31 July 2007, 12:54 GMT
Reason for closing:  Rejected
Additional comments about closing:  This idea was commited a while ago, but immediatly reverted because it was decided it wasnt worth the bin size cost
Comment by Paul van der Heu (paulheu) - Saturday, 01 April 2006, 21:04 GMT
small change

moved setting save to end of block (as suggested..)
Comment by Paul van der Heu (paulheu) - Saturday, 01 April 2006, 21:18 GMT
Ahum.. one should check a patch before uploading.. Revious one works, but needed -p1 ..

This one's tested and requires no 'special tricks..' :)
Comment by Matthias Mohr (aka Massa) (mmohr) - Thursday, 06 April 2006, 07:55 GMT
Good job!
Although I think each plugin should decide itself if it should allow to switch off the backlight or not.
It does absolutely make no sense for game plugins to switch off the backlight,
but e.g. for encoding or battery testing it does absolutely make sense!

So I suggest, to add a API function with which the plugins could decide theirselve if the backlight
should be switched off or not.

Nevertheless I resynched your patch with the current CVS (langv2 changes)...

Comment by Paul van der Heu (paulheu) - Thursday, 06 April 2006, 13:54 GMT
Actually this exists in the current API (backlight_on, backlight_off and backlight_set_timeout) but is never used it seems..

I just like the option to keep backlight on for plugins.. If it never makes it into CVS I'll stil use it, unless plugin writers start using the available options.. :^)
Comment by Matthias Mohr (aka Massa) (mmohr) - Friday, 07 April 2006, 11:59 GMT
As far as I know backlight_on switches the backlight on (for the moment),
backligh_off switches it off
and backlight_set_timeout changes the timeout for switching the backlight automatically off.
(correct me if I'm wrong)

That's not exactly what I meant.
I thought about an easy function, with which the plugin can either say
"don't ever switch the backlight off as long as I run"
or
"use the normal backlight settings" (DEFAULT)
or
"use my special timeout"

That's all - and this should then automatically be used as long as the plugin runs
and resets to normal behaviour when the plugin ends
(without further function call of the plugin itself).

BTW, grep at the plugin directory you'll find some backlight_on
and backlight_off calls ;)
Comment by Paul van der Heu (paulheu) - Tuesday, 22 August 2006, 15:57 GMT
Updated patch to prevent double patches in language file.

I would like to see this in CVS.. but if not Oh well.. ;^)
Comment by Chris (decayed.cell) - Saturday, 27 January 2007, 23:01 GMT
Requires updating for SVN
Comment by Paul van der Heu (paulheu) - Sunday, 28 January 2007, 10:53 GMT
It's really not that hard to do..
Comment by Chris (decayed.cell) - Sunday, 28 January 2007, 10:56 GMT
Sorry I don't know how to, I wish I knew... I'll try learning myself
Comment by Chris (decayed.cell) - Saturday, 03 February 2007, 06:30 GMT
Great patch works on 5.5G iPod 30GB. One suggestion: changes the options to On and Off to keep it consistent with the other backlight settings. Not sure if this is causing Doom to turn off the backlight in game though
Comment by Chris (decayed.cell) - Monday, 05 February 2007, 01:43 GMT
Tested on:

5.5G iPod
4G iPod Color
2G iPod Mini
1G iPod Nano
Comment by Chris (decayed.cell) - Monday, 05 February 2007, 07:20 GMT
Also tested on 4G Grayscale. SVN ready me thinks
Comment by Max Weninger (maxwen) - Saturday, 03 March 2007, 15:14 GMT
synced

Loading...