Rockbox

Tasklist

FS#4994 - BUGFIX: remove inappropriate "open with"

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Sunday, 02 April 2006, 15:41 GMT
Last edited by Barry Wardell (barrywardell) - Saturday, 28 July 2007, 12:15 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The patch removes an inappropriate "open with" option from the context menu when in WPS or DB view. The option only makes sense for a file in the file tree.
This task depends upon

Closed by  Barry Wardell (barrywardell)
Saturday, 28 July 2007, 12:15 GMT
Reason for closing:  Out of Date
Additional comments about closing:  This doesn't seem to be a problem any more with current SVN.
Comment by Dave Chapman (linuxstb) - Monday, 03 April 2006, 12:57 GMT
Why is that option inappropriate? It is used to (for example) open a currently playing/selected mp3 file in the splitedit or vbrfix plugin, or the currently playing/selected WAV file with either the MP3 or WavPack encoder.
Comment by Robert Kukla (roolku) - Monday, 03 April 2006, 14:50 GMT
Well, the reason I spotted the issue was that if you long-click on genre/artist etc in the tag DB view, you get the lonely option 'open with' which leads to an error regardless of what you select and definitly should not be there. I still consider open_with an action to be performed on a file while browsing and not "while playing". With the same reasoning you could have delete and rename in the WPS context menu (which I would find much more useful). With the addition of eq & pitch the context menu becomes rather cluttered.

BTW: the behaviour was introduced with http://www.rockbox.org/viewcvs.cgi/apps/onplay.c?rev=1.73&view=markup

Loading...