Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5022 - Better accuracy for peak-meter

Attached to Project: Rockbox
Opened by Jvo Studer (vinylivo) - Tuesday, 04 April 2006, 13:14 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch modifies the 'calc_db' function for better accuracy, less than 0.2dB error in important -12dB to 0dB range.

The pm_error.png graphic shows the error values. The red trace is the original difference between exact and claculated dB value. The green trace is for the improved accuracy calc_db function.
(application/octet-stream)    pm_calcdb_improved.patch (5.1 KiB) 
 /Users/jvostuder/SDK/rockbox-jsl060402/apps/recorder/peakmeter.c |  120 ++++------
 1 file changed, 55 insertions(+), 65 deletions(-)

   pm_error.png (8.1 KiB)
This task depends upon

Closed by  Peter D'Hoye (petur)
Monday, 03 July 2006, 00:37 GMT+2
Reason for closing:  Accepted
Comment by Brandon Low (lostlogic) - Wednesday, 05 April 2006, 16:08 GMT+2
Does this change peak meter speed at all?
Comment by Jvo Studer (vinylivo) - Saturday, 08 April 2006, 19:32 GMT+2
no unless for very small peak levels (24 or -62dB) there is one more if-else decision.
but first low level calls are very seldom and I doubt that this has an impact on speed.

new patch removes long path so u can use -p1 for patching.
(application/octet-stream)    pm_calcdb_improved_2.patch (5 KiB) 
 rockbox-jsl060402/apps/recorder/peakmeter.c |  120 ++++++++++++----------------
 1 file changed, 55 insertions(+), 65 deletions(-)

Loading...