Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5047 - Backlight: extended "filtering when off" option with hybrid modes

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Thursday, 06 April 2006, 12:44 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Saturday, 04 August 2007, 12:09 GMT+1
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This adds two more possible settings to the "First Keypress Enables Backlight Only" option (which is renamed to "Keypress effects when backlight is off").
Possible settings are now :
- "All: BL & action"
- "All: BL & no action"
- "Select: BL, others: action & BL"
- "Select: BL, Mode: action & BL, others: action"
(the strings are a little different for the H300, as i used the actual button names)

The titles hopefully speak for themselves... I tried to make it as clear as possible.
In the last choice, i felt it was necessary that the Mode button should turn the backlight on as well as perfirm its action, as it opens a menu.
(application/octet-stream)    backlight_filter.patch (9.5 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Saturday, 04 August 2007, 12:09 GMT+1
Reason for closing:  Rejected
Comment by Matthias Mohr (aka Massa) (mmohr) - Friday, 07 April 2006, 09:21 GMT+1
Sorry, I don't understand the settings.

"All: BL & action" - switches on backlight and does the key action
"All: BL & no action" - switches on backlight and does nothing else
"Select, others: action & BL" - ???
"Select: BL, Mode: action &BL, others: action" - ???

Are the settings duplicated for the remotes?

Something else:
IMHO the handling of the NON LCD remote should be different
from the onew with LCD.
Keypresses at the NON-LCD remote should affect the backlight
of the main devices - at least when navigating in the
filebrowser (I dont want to see the backlight of the main
device going on when changing the volume...)
Comment by Matthias Mohr (aka Massa) (mmohr) - Friday, 07 April 2006, 09:40 GMT+1
Ahh - now I understand!
"All" means "does not matter which key"
"Select" means "pressing the SELECT key" (PLAY on H300?)
"Mode" means "pressing the MODE key" (NAVI on H300?)
"others" means "pressing one of the other keys"

Is that correct?

How are the settings for the (different) remotes?
Comment by Nicolas Pennequin (nicolas_p) - Friday, 07 April 2006, 17:25 GMT+1
Yes, that's it. Just one thing : on the H300, Select = NAVI and Mode = A-B
This patch shouldn't affect the remote at all.
Comment by Norbert Preining (norbusan) - Sunday, 09 April 2006, 01:09 GMT+1
Hi all!

There seems to be a slight discrepancy here:
> "Select: BL, Mode: action &BL, others: action" - ???
> In the last choice, i felt it was necessary that the Mode button should turn the backlight on as well as perfirm its action, as it opens a menu.
> on the H300, Select = NAVI and Mode = A-B

If Mode=A-B, then Mode does not start the Menu. So for the H300 it should be:
A-B: only BL, NAVI: action&BL, others: only action no backlight

Great great great idea, I really want to have something like this. Please keep on pushing it!
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 09 April 2006, 01:12 GMT+1
Updated for current CVS.

norbulinka : on the H300, A-B opens the main menu, that's why I felt it was necessary to turn the backlight on when it's pressed.
(application/octet-stream)    backlight_filter_20060408.pat... (9.3 KiB)
Comment by Norbert Preining (norbusan) - Sunday, 09 April 2006, 21:23 GMT+1
Uups, true, I mixed this with the REC button. Thanks a lot
Comment by Dan FitzGerald (Danielson1218) - Tuesday, 11 April 2006, 03:52 GMT+1
With this patch in "Select: BL, Mode: action & BL, others: action" mode, a held action only key turns on the backlight, no matter what screen is being used. this is not entirely functional because the volume keys are often held in the wps, and directional keys are not always held in menus and the file tree. A possible remedy for this would be having the player respond as if "All: BL & action" was on when in the file tree and menus, and in the wps, have held action only buttons leave the backlight off. This might bloat the code to much, but if possible, this would perfect this patch in my eyes.
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 12 April 2006, 18:34 GMT+1
Dan: the backlight is handled in the button driver, so AFAICS it's not possible to make its behaviour context specific.
Comment by Vamsi Mohan (vamsimohan_6) - Tuesday, 20 June 2006, 14:57 GMT+1
Hi Nicholas is there any way you could modilfy this patch to include another option for this back light setting. Now that the rockbox has been updated to have a function for the record button (it shows the playlist that is being played) could you add another option to - "Select: BL, Mode: action & BL, others: action" so that even record button does action & BL.

Hope this is clear

Comment by Norbert Preining (norbusan) - Tuesday, 20 June 2006, 15:16 GMT+1
For Vamsi: The function for the record button is not generally available, but patched into some experimental builds for the H300.
Comment by Norbert Preining (norbusan) - Tuesday, 20 June 2006, 15:45 GMT+1
Here is a patch ON TOP of the backlight filter patch that adds this functionality. It is included in my build at http://www.misticriver.net/showthread.php?t=42675.
   rec-for-backlight-filtering.p... (1.6 KiB)
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 29 August 2006, 05:01 GMT+1
updated my patch for current CVS.
(application/octet-stream)    backlight_filter_20060829.pat... (9.3 KiB)
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 29 October 2006, 17:35 GMT+1
sync to current CVS
(application/octet-stream)    backlight_filter_20061029.pat... (9.2 KiB)
Comment by Nicolas Pennequin (nicolas_p) - Friday, 10 November 2006, 03:41 GMT+1
Sync again.
Devs, doesn't this patch interest you at all ?
   backlight_filter_20061110.pat... (9.2 KiB)
Comment by Norbert Preining (norbusan) - Friday, 10 November 2006, 07:27 GMT+1
Hi Nicolas!
I include your patch in the my builds, and I also add the following small change to it that makes REC be treated like MENU, because I also include the rec-button patch (via the recordings enhancements pack).
   rec-for-backlight-filtering.p... (1.6 KiB)
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 20 December 2006, 17:49 GMT+1
Updated for current CVS
   backlight_filter_20061219.pat... (9.6 KiB)
Comment by Norbert Preining (norbusan) - Sunday, 28 January 2007, 00:11 GMT+1
Hi Nicolas!
Any chance that you come around fixing this for the new settings.c code?
Thanks a lot, Norbert
Comment by Paul van der Heu (paulheu) - Sunday, 28 January 2007, 11:58 GMT+1
I overlooked this one .. If all goes well I might be able to fix the patch today..
Comment by Paul van der Heu (paulheu) - Sunday, 28 January 2007, 12:14 GMT+1
Simple really..
   backlight_filter_070128.patch (8.3 KiB)
Comment by Norbert Preining (norbusan) - Tuesday, 08 May 2007, 10:36 GMT+1
Hi all!
Can anyone sync this patch to current SVN, that would be great.

Thanks a lot and all the best
Norbert
Comment by Michael Hahn (disorganizer) - Wednesday, 13 June 2007, 22:59 GMT+1
also being able to configure exactly which buttons to react on and on which buttons not to react would be nice.

another question:
if i turn off the BL on all buttons with this patch, will the backlight go on if i press the buttons sucessively (for example 2 times forward)?

or does this patch turn off the backlight for those buttons for any number of keypresses?
Comment by Nick Brackley (darksaboteur) - Friday, 13 July 2007, 03:59 GMT+1
Any chance of a sync? Its a very useful patch, should be included in SVN
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 22 July 2007, 17:57 GMT+1
This patch will apply cleanly, but I'm not sure it'll work properly, as I currently don't have an H300 to test it on.
   backlight_filter_r13957.patch (7.9 KiB)
Comment by Nick Brackley (darksaboteur) - Monday, 23 July 2007, 06:15 GMT+1
Tested the patch on my H300 and it works beautifully :). I will let you know if I find any bugs. Thanks again :)

Loading...