Rockbox

Tasklist

FS#5061 - JPEG viewer - next image when zoomed in does not work

Attached to Project: Rockbox
Opened by Nothanks Google (Suntiger) - Friday, 07 April 2006, 15:11 GMT
Last edited by Peter D'Hoye (petur) - Monday, 01 May 2006, 20:43 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Oddly enough, after the inclusion of the JPEG viewer menu patch in CVS, the buttons in the JPEG viewer which were previously used to move to the next and previous images no longer work. (on iPods, this was select+right/left).

They're still defined in the code: (JPEG_PREVIOUS and JPEG_NEXT)

#elif (CONFIG_KEYPAD == IPOD_3G_PAD) || (CONFIG_KEYPAD == IPOD_4G_PAD)
#define JPEG_ZOOM_IN BUTTON_SCROLL_FWD
#define JPEG_ZOOM_OUT BUTTON_SCROLL_BACK
#define JPEG_UP BUTTON_MENU
#define JPEG_DOWN BUTTON_PLAY
#define JPEG_LEFT BUTTON_LEFT
#define JPEG_RIGHT BUTTON_RIGHT
#define JPEG_MENU (BUTTON_SELECT | BUTTON_MENU)
#define JPEG_NEXT_PRE (BUTTON_SELECT | BUTTON_RIGHT)
#define JPEG_NEXT (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REL)
#define JPEG_TOGGLE_SLIDESHOW (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REPEAT)
#define JPEG_PREVIOUS (BUTTON_SELECT |BUTTON_LEFT)

but when pressed, nothing happens.

Moving to next or previous works fine when zoomed out.
Closed by  Dave Chapman (linuxstb)
Saturday, 20 May 2006, 13:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in CVS
Comment by Nothanks Google (Suntiger) - Friday, 07 April 2006, 15:12 GMT
Damn, category again... should be "plugins"
Comment by Nothanks Google (Suntiger) - Wednesday, 19 April 2006, 20:55 GMT
Replacing the above with the following code fixes the issue:

#elif (CONFIG_KEYPAD == IPOD_3G_PAD) || (CONFIG_KEYPAD == IPOD_4G_PAD)
#define JPEG_ZOOM_IN BUTTON_SCROLL_FWD
#define JPEG_ZOOM_OUT BUTTON_SCROLL_BACK
#define JPEG_UP BUTTON_MENU
#define JPEG_DOWN BUTTON_PLAY
#define JPEG_LEFT BUTTON_LEFT
#define JPEG_RIGHT BUTTON_RIGHT
#define JPEG_MENU (BUTTON_SELECT | BUTTON_MENU)
#define JPEG_NEXT (BUTTON_SELECT | BUTTON_RIGHT)
/*#define JPEG_NEXT (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REL)*/
#define JPEG_TOGGLE_SLIDESHOW (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REPEAT)
#define JPEG_PREVIOUS (BUTTON_SELECT | BUTTON_LEFT)
Comment by Alexander Spyridakis (xaviergr) - Saturday, 20 May 2006, 13:33 GMT
Look at patch #5362

Loading...