Rockbox

ircnick:sharpe checked an ondio sim for me, the patch is fine :)

and ho, yeah, someone should put it into the manual as well :)

http://www.rockbox.org/tracker/task/5073

the line:
xrect = MAX(w - offset, 0);
in all LCD driver should be: xrect = xpos + MAX(w - offset, 0);
please do not commit before changing

The right, working file. Btw, this also _really_ fixes http://www.rockbox.org/tracker/task/5267 (I was the one who wrote horizontal screen scroll, a long time ago we had an irc conversation that it is better if screen scrolling would not need to use two keys combination, and a short while a go I had time to write it down. It also fixes a behaviour whereas holding RIGHT key on a folder will enter subfolders very quickly, an unwanted behaviour for sure ( BUTTON_RIGHT | BUTTON_REPEAT is removed) )

   screen_scroll_oneclick_5.4.06 (11.4 KiB)

I have committed the cropping fix. I have no opinion about the key mapping, so I'll probably commit that as well, as I'm a big fan of one-handed operation.

Here's an updated version without the bug fix.

   screen_scroll_20060506.patch (6.4 KiB)

@ Linus:

You should have checked the previous commits before committing this. Peter D'Hoye fixed the inverse bar issue 3 days ago.

The only difference between his fix and your commit is that he didn't clamp the value to zero but let it become negative under certain conditions. That doesn't hurt though, as lcd_fillrect() catches this and returns immediately. His version saved a bit of code…

Yes, he made an attempt to fix it. It was not 100% succesful though, see http://www.rockbox.org/tracker/task/5267.

Jens, I'm sorry, you're wrong. because he let the numbers get negative, the Icons (on the left) got color-inverted, at least on the h1x0 (which shouldn't really be any diffrent from any other target, I'm just not l00king at the code right now).
Think about it this way: the filling rect from the right side of the text did not 'stopped' at the left side boarder and 'filled' the icon.

Linus, I believe you haven't submitted the key mapping code,
a. why is that?
b. I think it broke the sudoko menu, but I haven't had time to see what caused me the problem (the menu was not responsive at all, I had to shut down).

a) Because I wanted to fix the bug without changing an existing feature.

b) What broke the Sudoku menu?

b. The Sudoku menu caught menu enter downpresses and was activated on button release (MENU_ENTER became BUTTON_NONE, and MENU_ENTER | BUTTON_REL became MENU_ENTER.)
I'm not sure why is was introduced in such a way, other then the comment saying 'next menu doesn't like release'.
This code isn't necessary with the screen scroll hold button patch for targets that actually uses it, but I assume ONDIO's should still use it : "The ONDIO is the only player that still uses MENU + LEFT / RIGHT combination, because it's RIGHT_REPEAT button is already occupied with the TREE_CONTEXT menu."

I would have checked it myself but I can't get Vmware simulators running… they are all corrupted for me. ##$%#%Y$.
so someone should #ifdef it properly or tell me how to solve the Vmware issue :P

a.huh, I guess I have nothing to say about that.

   sudoku_fix.patch (1.2 KiB)

Any news about the Ondio compatibility with this patch?

The patch was fine for ondio, but I added one more lastbutton check so that screen scrolling would work on ondio menu system. (without it, pressing menu would have left the menu on click, now it's on release.)

I do remind sudoku_fix.patch is importent for this patchfile.

   oneclick_screenscroll_02 (6.3 KiB)