Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5193 - configurable caption backlight

Attached to Project: Rockbox
Opened by Wolfgang Weisselberg (weissel) - Friday, 21 April 2006, 00:59 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 05 June 2011, 13:41 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I like the caption backlight (and it's 100% COOL), but I (currently) tend to
not want to look at the old song, but at the new song when it is already
playing 10 or 15 seconds.

By then the caption backlight is easily too soon off again :-/

Thus I respectfully request:
A configuration option "caption backlight before end" and "caption backlight
after start", both in a range of, say, -15 to 45 seconds.

So with "caption backlight before end" = -5 and "caption backlight after
start" = 25 the CB would come on 5 seconds after the new song has begone and
it'd shut off 25 seconds after the song started. Disallow bad combinations of
start and end (i.e. end time -5 and start time 3), or simply let the CB off in
these cases.
This task depends upon

Closed by  Thomas Martitz (kugel.)
Sunday, 05 June 2011, 13:41 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  There doesn't seem to be interest in this anymore. Open a new task if this is wrong.
Comment by Enno (onkel_enno) - Tuesday, 06 November 2007, 11:37 GMT+2
It's my first patch and I don't know much C but it works fines for me.
Maybe someone with more C Skills can have a look at it.
And it's only for the backlight, not for the remote_backlight since I can't test it.

BTW You can now choose the time before the track ends and the backlight goes on.
The time the backlight is on for the next song is still the backligh_on time.
   FS5193-20071106.patch (4.1 KiB) 
 ../settings/apps/gui/gwps-common.c      |   11 ++++-------
 ../settings/apps/settings.h             |    2 +-
 ../settings/apps/settings_list.c        |   19 +++++++++++++++++--
 ../settings/firmware/backlight.c        |    4 ++++
 ../settings/firmware/export/backlight.h |    1 +
 5 files changed, 27 insertions(+), 10 deletions(-)

Loading...