Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5316 - Rockdoom Dehacked/BEX support

Attached to Project: Rockbox
Opened by Karl Kurbjun (kkurbjun) - Monday, 08 May 2006, 00:55 GMT+2
Task Type Patches
Category Games
Status Closed
Assigned To Karl Kurbjun (kkurbjun)
Player Type All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here's an initial patch for dehacked support in rockdoom. Right now it only supports dehacked files in a wad. I was testing this patch with wolfendoom's 2nd_end.wad by inserting the given dehacked patch into the wad titled DEHACKED. I'm not sure if this patch will fit on ipods. Also, it adds in compiling sscanf to rockbox's core and fixes some of it's functionality. Since I don't have a strnicmp or the other icmp functions the dehacked file has to match the string cases in d_deh.c. For wolfendoom this was already the case, so no modification was needed.

Finally, this patch is made to create a log at /dehlog.txt to keep track of everything the dehacked loader is doing if a DEHACKED lump is detected.
   doomdehacked.diff (45.9 KiB) 
 apps/plugin.c                  |    2 
 apps/plugin.h                  |    2 
 apps/plugins/Makefile          |    2 
 apps/plugins/doom/Makefile     |    2 
 apps/plugins/doom/am_map.c     |   16 +--
 apps/plugins/doom/d_main.c     |   17 +++
 apps/plugins/doom/f_finale.c   |  103 +++++++++++------------
 apps/plugins/doom/g_game.c     |    2 
 apps/plugins/doom/hu_stuff.c   |  181 +----------------------------------------
 apps/plugins/doom/hu_stuff.h   |    8 -
 apps/plugins/doom/i_sound.c    |    2 
 apps/plugins/doom/m_menu.c     |   49 ++++-------
 apps/plugins/doom/p_doors.c    |   14 +--
 apps/plugins/doom/p_inter.c    |   77 ++++++++---------
 apps/plugins/doom/p_pspr.c     |    4 
 apps/plugins/doom/p_spec.c     |   20 ++--
 apps/plugins/doom/rockmacros.h |    4 
 firmware/SOURCES               |    1 
 firmware/common/sscanf.c       |   27 +++++-
 19 files changed, 203 insertions(+), 330 deletions(-)

   d_deh.c (119.4 KiB)
   d_deh.h (40.7 KiB)
This task depends upon

Closed by  Karl Kurbjun (kkurbjun)
Wednesday, 13 December 2006, 06:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in CVS
Comment by Karl Kurbjun (kkurbjun) - Monday, 08 May 2006, 01:01 GMT+2
Here's the modified 2nd_enc.wad to include the dehacked file. You can download the original file from: http://www.doomworld.com/wolfendoom/index.shtml
Comment by Karl Kurbjun (kkurbjun) - Monday, 08 May 2006, 01:06 GMT+2
I guess it didn't want to attach (didn't realize how large it was), here's a link: http://alamode.mines.edu/~kkurbjun/dehacktst.wad
Comment by Karl Kurbjun (kkurbjun) - Monday, 08 May 2006, 21:41 GMT+2
Here's a new patch that fits on the ipods also. To do this I changed the compiler flags for the ipods to -Os and added a few malloc tweaks. I'm not sure what the speed penalty is though for the ipods. Use d_deh.c and d_deh.h from the first post.
   doomiv.diff (51.7 KiB) 
 apps/plugin.c                  |    2 
 apps/plugin.h                  |    2 
 apps/plugins/Makefile          |    2 
 apps/plugins/doom/Makefile     |    7 -
 apps/plugins/doom/am_map.c     |   16 +-
 apps/plugins/doom/d_main.c     |   17 ++
 apps/plugins/doom/f_finale.c   |  103 ++++++++---------
 apps/plugins/doom/g_game.c     |    2 
 apps/plugins/doom/hu_stuff.c   |  245 +++++++----------------------------------
 apps/plugins/doom/hu_stuff.h   |    8 -
 apps/plugins/doom/i_sound.c    |    2 
 apps/plugins/doom/m_menu.c     |   49 +++-----
 apps/plugins/doom/p_doors.c    |   14 +-
 apps/plugins/doom/p_inter.c    |   77 ++++++------
 apps/plugins/doom/p_pspr.c     |    4 
 apps/plugins/doom/p_spec.c     |   20 +--
 apps/plugins/doom/rockmacros.h |    4 
 firmware/SOURCES               |    1 
 firmware/common/sscanf.c       |   27 ++++
 19 files changed, 245 insertions(+), 357 deletions(-)

Comment by Karl Kurbjun (kkurbjun) - Monday, 08 May 2006, 21:47 GMT+2
As an added note, this patch will allow other language translations in doom through the BEX/DEH patches. I'm not sure if any already exist though.
Comment by Jens Arnold (amiconn) - Wednesday, 10 May 2006, 09:02 GMT+2
Rockbox does have strcasecmp() and strncasecmp() which are functionally identical to stricmp() and strnicmp(). They are even already available in the plugin api.
Comment by Karl Kurbjun (kkurbjun) - Wednesday, 10 May 2006, 16:41 GMT+2
: ), oops, thanks for the tip, I'll use those instead. What's your opinion on adding building sscanf with the core? Was there a reason it wasn't being built before?
Comment by Karl Kurbjun (kkurbjun) - Saturday, 03 June 2006, 19:49 GMT+2
Here's the latest version of the patch, fixes all the strncasecmp stuff.
   doomdehacked.diff (51.6 KiB) 
 apps/plugin.c                  |    2 
 apps/plugin.h                  |    2 
 apps/plugins/Makefile          |    2 
 apps/plugins/doom/Makefile     |    7 -
 apps/plugins/doom/am_map.c     |   16 +-
 apps/plugins/doom/d_main.c     |    8 +
 apps/plugins/doom/dstrings.h   |    2 
 apps/plugins/doom/f_finale.c   |  103 ++++++++---------
 apps/plugins/doom/g_game.c     |    2 
 apps/plugins/doom/hu_stuff.c   |  245 +++++++----------------------------------
 apps/plugins/doom/hu_stuff.h   |    8 -
 apps/plugins/doom/i_sound.c    |    2 
 apps/plugins/doom/m_menu.c     |   49 +++-----
 apps/plugins/doom/p_doors.c    |   14 +-
 apps/plugins/doom/p_inter.c    |   77 ++++++------
 apps/plugins/doom/p_pspr.c     |    4 
 apps/plugins/doom/p_spec.c     |   20 +--
 apps/plugins/doom/rockmacros.h |    4 
 firmware/SOURCES               |    1 
 firmware/common/sscanf.c       |   27 ++++
 20 files changed, 237 insertions(+), 358 deletions(-)

   d_deh.c (119.1 KiB)
   d_deh.h (40.7 KiB)
Comment by fcuk (fcuk) - Thursday, 14 September 2006, 13:13 GMT+2
I was just asking if u can mod halflife.wad located in http://www.gp32x.de/cgi-bin/cfiles.cgi?0,0,0,0,24,331, and if your patch can solve the problem for rockdoom displaying "The wad does not follow standard doom graphics" error, if yes please tell me how I can apply it to rockbox.

Thanks,
Karl
Comment by Karl Kurbjun (kkurbjun) - Thursday, 14 September 2006, 18:04 GMT+2
This patch does not fix halflife or any of those GP32 wad files. These wad files do alot of nasty things to doom which is all explained in this forum post http://forums.rockbox.org/index.php?topic=4200.0 This patch allows wads that used some of dooms advanced modification features (that were not originally available to mod authors with ID's original doom release). An explanation of Dehacked is here: http://en.wikipedia.org/wiki/Dehacked. This patch is primarily for mods like wolfendoom, batman doom, aliens doom, etc. to all work properly. I plan on commiting this patch once I get my computer running with a development environment again.
Comment by fcuk (fcuk) - Thursday, 14 September 2006, 22:00 GMT+2
Karl, can u please tell me how can I run halflife without displaying the error I mentioned above, cuz I've seen a video of someone's 5G iPod running halflife wad on rockdoom there http://www.youtube.com/watch?v=Ra6rqKSqBSk, how could he do it ?

The wad displays the errors and despite loads the first screen from half life and exits back to the rockbox's plugin menu.

Thanks Again,

Loading...