Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5355 - Recording on X5 (initial support)

Attached to Project: Rockbox
Opened by Anonymous Submitter - Saturday, 13 May 2006, 16:07 GMT+2
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Player Type iAudio X5
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Here's a patch that will enable recording on the X5.

- Mic works fine
- Line-in does not work yet (maybe GPIO 29 is not enough to switch from radio?)
- Peakmeater works (!)
- 44.1 kHz recording to WAV

Recording gain (volume) does not work correctly yet. Help wanted.

Cheers
/Andy
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Friday, 21 July 2006, 14:16 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed along with  FS#5347 . Thanks!
Comment by Andy Young (andy) - Saturday, 13 May 2006, 16:16 GMT+2
Here's the patch
(application/octet-stream)    x5_record.patch (16.4 KiB) 
 apps/main.c                       |    4 -
 apps/recorder/recording.c         |   15 +++++
 firmware/pcm_record.c             |  104 +++++++++++++++++++++++++++-----------
 firmware/sound.c                  |   20 +++++++
 firmware/drivers/tlv320.c         |   61 ++++++++++++----------
 firmware/export/config-iaudiox5.h |    2 
 firmware/export/sound.h           |    2 
 firmware/export/tlv320.h          |    2 
 8 files changed, 150 insertions(+), 60 deletions(-)

Comment by Rani Hod (RaeNye) - Sunday, 14 May 2006, 01:10 GMT+2
Great work!

Does recording from FM radio work?
(Combine this patch with mine: http://www.rockbox.org/tracker/task/5347 . I'll do it in a few days if you don't :)

Also, try to enable AAP_BYPASS and see if you can hear line-in on the headphones.
Comment by Andy Young (andy) - Sunday, 14 May 2006, 23:33 GMT+2
New version of the patch

Gain settings and line-in now works!

- Mic gain (0 or 20 dB)
- Line-in gain (-34 .. 12 dB)

/Andy
(application/octet-stream)    x5_record_2.patch (17.1 KiB) 
 apps/main.c                       |    4 -
 apps/recorder/recording.c         |   14 +++++
 firmware/pcm_record.c             |  103 +++++++++++++++++++++++++++-----------
 firmware/sound.c                  |   23 ++++++++
 firmware/drivers/tlv320.c         |   87 ++++++++++++++++++++------------
 firmware/export/config-iaudiox5.h |    2 
 firmware/export/sound.h           |    2 
 firmware/export/tlv320.h          |    2 
 8 files changed, 173 insertions(+), 64 deletions(-)

Comment by Rani Hod (RaeNye) - Monday, 10 July 2006, 01:12 GMT+2
Resynced to current CVS.

If you want FM radio as well, consider getting FS #5347
(http://www.rockbox.org/tracker/task/5347) since it is now contains record-v2 as a part of it.
(application/octet-stream)    x5-record-v2-synced-060710.patch (16.7 KiB) 
 firmware/drivers/tlv320.c         |   87 +++++++++++++++++++-----------
 firmware/export/config-iaudiox5.h |    2 
 firmware/export/sound.h           |    2 
 firmware/export/tlv320.h          |    2 
 firmware/pcm_record.c             |  108 +++++++++++++++++++++++++++-----------
 firmware/sound.c                  |   25 ++++++++
 apps/main.c                       |    4 -
 apps/recorder/recording.c         |   14 ++++
 8 files changed, 177 insertions(+), 67 deletions(-)

Comment by Dave Chapman (linuxstb) - Monday, 17 July 2006, 14:09 GMT+2
A minor comment - this patch changes how the SETTINGS_RESET button is defined in apps/main.c. This should still be wrapped around keypad-specific #ifdefs - ipods don't have SETTINGS_RESET defined to be BUTTON_REC, and although they don't current record, they will do in the future.

Loading...