Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5364 - "NAVI = Yes" for iRiver H100/H120/H300 (most languages)

Attached to Project: Rockbox
Opened by Alexander Bondar (davinci) - Monday, 15 May 2006, 13:52 GMT+2
Last edited by Matthias Mohr (aka Massa) (mmohr) - Sunday, 30 July 2006, 20:35 GMT+2
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Version 3.0
Due Date Undecided
Percent Complete 100%
Private No

Details

No more wrong "PLAY = Yes" in the dialogs. Now "NAVI = Yes" in Eglish and "NAVI = Ja" in German language files.
(application/octet-stream)    h300_navi_20060513.patch (1.1 KiB) 
 apps/lang/english.lang |    3 +++
 apps/lang/deutsch.lang |    3 +++
 2 files changed, 6 insertions(+)

This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Sunday, 30 July 2006, 21:18 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks. How about fixing the remaining LANG_BOOKMARK_SELECT_PLAY entries too?
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 15 May 2006, 14:27 GMT+2
I think it would be better to call it SELECT instead of NAVI. In Rockbox, the joystick button has always been SELECT, and it works for the X5 as well.
Comment by Alexander Bondar (davinci) - Monday, 15 May 2006, 14:29 GMT+2
But "NAVI" is writen on the button.
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 15 May 2006, 14:30 GMT+2
Not on the H100, and we'd like to treat both platforms the same.

Comment by Alexander Bondar (davinci) - Monday, 15 May 2006, 14:36 GMT+2
So why do we have "h100" and "h300" for the language files?
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 15 May 2006, 14:51 GMT+2
My point is that we want to have a common name for the joystick button on all the joystick targets. Maybe that's not a good idea, what do you think?
Comment by Alexander Bondar (davinci) - Monday, 15 May 2006, 15:47 GMT+2
H300 has on itself no joystick. Joystick can be used for more actions than the NAVI button (only press or hold).

And I don't think that all H300/H100 user own a remote.
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 15 May 2006, 15:58 GMT+2
Of course. Then it should be NAVI on the H300 at least, like your patch suggests.
Comment by Alexander Bondar (davinci) - Monday, 15 May 2006, 17:27 GMT+2
Will you add this patch to CVS?
Comment by Peter D'Hoye (petur) - Tuesday, 23 May 2006, 14:46 GMT+2
and call the h1x0 joystick 'joystick'
Comment by Mike Schmitt (Falco98) - Tuesday, 06 June 2006, 05:00 GMT+2
"navi" is written on the h100 on the remote...?
Comment by Benoit-Pierre Guay (benacool) - Thursday, 29 June 2006, 16:16 GMT+2
Mike (Falco98) said : "navi" is written on the h100 on the remote...?

Yes, on the H100 remote, the button to go in the browser and in the settings menu is named "NAVI/MENU".
Comment by Benoit-Pierre Guay (benacool) - Thursday, 29 June 2006, 16:20 GMT+2
Little error... Forget the "and in the settings menu" I said in my last comment.
Comment by Matthias Mohr (aka Massa) (mmohr) - Sunday, 30 July 2006, 16:04 GMT+2
Here is an updated patch which calls it
"NAVI = yes" for h300 and
"SELECT = yes" for h100/h120
for all languages except japanese and hebrew
(I'm unable to edit those at my system...)
and afrikaans, bulgarian, romaneste and turkce
(they don't contain that LANG-ID - are they up to date?)

BTW, there have been a few lanuages (e.g. catala) where
the "NAVI = yes" for h300 is already included in CVS!
(application/octet-stream)    lang_confirm_with_play-MM-20060730.patch (12.3 KiB) 
 apps/lang/catala.lang         |    1 +
 apps/lang/chinese-trad.lang   |    2 ++
 apps/lang/czech.lang          |    2 ++
 apps/lang/dansk.lang          |    2 ++
 apps/lang/deutsch.lang        |    3 +++
 apps/lang/english.lang        |    3 +++
 apps/lang/espanol.lang        |    2 ++
 apps/lang/esperanto.lang      |    2 ++
 apps/lang/finnish.lang        |    2 ++
 apps/lang/francais.lang       |    2 ++
 apps/lang/galego.lang         |    2 ++
 apps/lang/greek.lang          |    2 ++
 apps/lang/islenska.lang       |    2 ++
 apps/lang/italiano.lang       |    2 ++
 apps/lang/korean.lang         |    4 +++-
 apps/lang/magyar.lang         |    2 ++
 apps/lang/nederlands.lang     |    2 ++
 apps/lang/norsk-nynorsk.lang  |    2 ++
 apps/lang/norsk.lang          |    2 ++
 apps/lang/polski-ascii.lang   |    2 ++
 apps/lang/polski.lang         |    2 ++
 apps/lang/portugues.lang      |    2 ++
 apps/lang/russian.lang        |    2 ++
 apps/lang/slovenscina.lang    |    2 ++
 apps/lang/svenska.lang        |    2 ++
 apps/lang/wallisertitsch.lang |    2 ++
 26 files changed, 54 insertions(+), 1 deletion(-)

Comment by Linus Nielsen Feltzing (linusnielsen) - Sunday, 30 July 2006, 17:13 GMT+2
After some discussion on IRC, we have come to the conclusion that it should be called "NAVI" on both H100 and H300, since the original iriver manual calls it NAVI.
Care to fix? Then I will commit.
Comment by Matthias Mohr (aka Massa) (mmohr) - Sunday, 30 July 2006, 20:34 GMT+2
O.K. here is a version with "NAVI" for both the H100, H120 and H3x0...

BTW, is "PLAY" O.K. for all other targets?
Or would it be better for them to also have a different name for them?

(application/octet-stream)    lang_confirm_with_play-MM-20060730-2.patch (12.3 KiB) 
 apps/lang/catala.lang         |    1 +
 apps/lang/chinese-trad.lang   |    2 ++
 apps/lang/czech.lang          |    2 ++
 apps/lang/dansk.lang          |    2 ++
 apps/lang/deutsch.lang        |    3 +++
 apps/lang/english.lang        |    3 +++
 apps/lang/espanol.lang        |    2 ++
 apps/lang/esperanto.lang      |    2 ++
 apps/lang/finnish.lang        |    2 ++
 apps/lang/francais.lang       |    2 ++
 apps/lang/galego.lang         |    2 ++
 apps/lang/greek.lang          |    2 ++
 apps/lang/islenska.lang       |    2 ++
 apps/lang/italiano.lang       |    2 ++
 apps/lang/korean.lang         |    4 +++-
 apps/lang/magyar.lang         |    2 ++
 apps/lang/nederlands.lang     |    2 ++
 apps/lang/norsk-nynorsk.lang  |    2 ++
 apps/lang/norsk.lang          |    2 ++
 apps/lang/polski-ascii.lang   |    2 ++
 apps/lang/polski.lang         |    2 ++
 apps/lang/portugues.lang      |    2 ++
 apps/lang/russian.lang        |    2 ++
 apps/lang/slovenscina.lang    |    2 ++
 apps/lang/svenska.lang        |    2 ++
 apps/lang/wallisertitsch.lang |    2 ++
 26 files changed, 54 insertions(+), 1 deletion(-)

Loading...