Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5483 - Recording: Track split button

Attached to Project: Rockbox
Opened by Martin Scarratt (mmmm-) - Saturday, 03 June 2006, 01:16 GMT+2
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

A possible new addition to the REP.

Pressing the record button with this patch will start up a new file continuing seamlessly from the previous one (so you can add track splits in real time). I've moved the pause function to the play key (which I was always pressing when i wanted it to pause anyway! Cheesy )

Try it out, tell me what's wrong with it and all the usual stuff...

Only implemented for irivers at the mo....not sure about the buttons to use on other targets but would be very easy to put in. Any suggestions?

The other targets with recording are the Ondio and Gmini100 I think. It would be ideal if we could have the present recording button as the Record/new file button and another button as pause. But which button on these would be good for pause? Is there a spare button at all on those targets?
(application/octet-stream)    manualrecordingsplit.patch (3 KiB) 
 apps/recorder/recording.c |   48 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Martin Scarratt (mmmm-)
Saturday, 22 July 2006, 13:08 GMT+2
Reason for closing:  Accepted
Comment by Martin Scarratt (mmmm-) - Sunday, 04 June 2006, 14:14 GMT+2
Update: Now the filename is displayed above the peakmeter so you can keep track of how many times you have split.
This only applies if the screen height is > 72 pixels so it wont break any targets with small screens (including the remote)
   manualrecordingsplitfilename.patch (11.9 KiB) 
 apps/recorder/peakmeter.c |   11 +++--
 apps/recorder/peakmeter.h |    2 
 apps/recorder/recording.c |   97 +++++++++++++++++++++++++++++++++++++---------
 3 files changed, 88 insertions(+), 22 deletions(-)

Comment by Martin Scarratt (mmmm-) - Sunday, 04 June 2006, 19:07 GMT+2
Update: looked at the other targets and the keys for the Archos recorder remain the same except I've put the ON button as the start new file button.

The Ondio doesn't seem to have any keys left, so it can't have this functionality
The Gmini keymappings don't seem to be complete for the recording screen anyway so I'm not going to touch them.

So to make a long story longer this patch changes the following targets' keymappings in the recording screen:
IRiver H100/H120/H140/H320/H340
Play/Pause/On button: Start recording/Pause Recording
Record button: Begin recording into new file
Archos Recorder
On button: Begin recording into new file

All other targets remain as they were.

   manualrecordingsplitfilename.patch (12.3 KiB) 
 apps/recorder/peakmeter.c |   11 +++--
 apps/recorder/peakmeter.h |    2 
 apps/recorder/recording.c |   98 +++++++++++++++++++++++++++++++++++++---------
 3 files changed, 89 insertions(+), 22 deletions(-)

Comment by Martin Scarratt (mmmm-) - Tuesday, 20 June 2006, 17:14 GMT+2
Scrub that last comment... (and the last patch) the Archos already has this feature! HA HA...I should do my homework before I code! :D

Patch 2 is the one you want :)
Comment by Martin Scarratt (mmmm-) - Monday, 26 June 2006, 18:35 GMT+2
Slightly better handling of the filename offset.
   manualrecordingsplit.patch (11.7 KiB) 
 apps/recorder/peakmeter.c |    6 +-
 apps/recorder/peakmeter.h |    2 
 apps/recorder/recording.c |   99 +++++++++++++++++++++++++++++++++++++---------
 3 files changed, 85 insertions(+), 22 deletions(-)

Loading...