Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5522 - WPS at plugins

Attached to Project: Rockbox
Opened by Ben Basha (paprica) - Friday, 09 June 2006, 19:19 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 02 August 2007, 14:54 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details


allows to play/pause, inc/dec volume, stop,
change songs, change pitch, ff/fr etc...

i add it to brickmania only right now.

i check it only in h300,
please check it on the other targets.

comments?
   plugin_wps.patch (10.8 KiB) 
 apps/action.h             |    1 
 apps/onplay.c             |   14 +++++++----
 apps/plugin.c             |    3 ++
 apps/plugin.h             |    4 ++-
 apps/tree.c               |    2 -
 apps/gui/gwps.c           |   58 ++++++++++++++++++++++++++++++++++------------
 apps/gui/gwps.h           |    2 -
 apps/plugins/brickmania.c |   25 ++++++++++++++++---
 8 files changed, 82 insertions(+), 27 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 02 August 2007, 14:54 GMT+2
Reason for closing:  Rejected
Comment by Paul Louden (darkkone) - Saturday, 10 June 2006, 07:08 GMT+2
Does this actually show the WPS?

Wouldn't it be better to just use the Playback Menu that some plugins already have?
Comment by Ben Basha (paprica) - Saturday, 10 June 2006, 16:09 GMT+2
> Does this actually show the WPS?

yes it does


> Wouldn't it be better to just use the Playback Menu that some plugins already have?

I think that it's better than the Playback Menu because of this is show the all wps with the name of the song and all.
also you can open the onplay menu from the wps and go to the sound menu, change the eq settings etc..
Comment by Zakk Roberts (midkay) - Monday, 12 June 2006, 02:44 GMT+2
I like this idea. It's simpler to adjust nearly everything already in the Playback Menu we've already got, plus it allows you to adjust a *lot* more, like playlist order, pitch, sound settings...
Comment by Ben Basha (paprica) - Monday, 12 June 2006, 08:06 GMT+2
you cant adjust the playlist order because the playlist viewer use the plugin buffer
Comment by Hardeep Sidhu (hardeeps) - Monday, 12 June 2006, 08:12 GMT+2
The playlist api to change order can be called from anywhere, it's not specific to the viewer (nor are any of the other playlist manipulation routines). The buffer is only used by the viewer to cache names for display.

Loading...